Re: [Intel-gfx] [PATCH] drm/i915: fix up ilk rc6 disabling confusion

2012-07-04 Thread Daniel Vetter
On Sat, Jun 30, 2012 at 08:04:44PM -0700, Ben Widawsky wrote: > On Fri, 29 Jun 2012 23:32:16 +0200 > Daniel Vetter wrote: > > > While creating the new enable/disable_gt_powersave functions in > > > > commit 8090c6b9daa04dda649ac0a2209601042abfb0a4 > > Author: Daniel Vetter > > Date: Sun Jun 2

Re: [Intel-gfx] [PATCH] drm/i915: fix up ilk rc6 disabling confusion

2012-07-02 Thread Daniel Vetter
On Mon, Jul 02, 2012 at 08:44:00AM -0700, Ben Widawsky wrote: > On Sun, 1 Jul 2012 12:48:59 +0200 > Daniel Vetter wrote: > > Hm, I don't see the comment you're talking about ... Neither > > ironlake_disable_rc6 nor ironlake_teardown_rc6 nor any of the callers > > have one. Or am I totally missing

Re: [Intel-gfx] [PATCH] drm/i915: fix up ilk rc6 disabling confusion

2012-07-02 Thread Ben Widawsky
On Sun, 1 Jul 2012 12:48:59 +0200 Daniel Vetter wrote: > On Sun, Jul 1, 2012 at 5:04 AM, Ben Widawsky wrote: > > On Fri, 29 Jun 2012 23:32:16 +0200 > > Daniel Vetter wrote: > > > >> While creating the new enable/disable_gt_powersave functions in > >> > >> commit 8090c6b9daa04dda649ac0a220960104

Re: [Intel-gfx] [PATCH] drm/i915: fix up ilk rc6 disabling confusion

2012-07-01 Thread Daniel Vetter
On Sun, Jul 1, 2012 at 5:04 AM, Ben Widawsky wrote: > On Fri, 29 Jun 2012 23:32:16 +0200 > Daniel Vetter wrote: > >> While creating the new enable/disable_gt_powersave functions in >> >> commit 8090c6b9daa04dda649ac0a2209601042abfb0a4 >> Author: Daniel Vetter >> Date: Sun Jun 24 16:42:32 2012

Re: [Intel-gfx] [PATCH] drm/i915: fix up ilk rc6 disabling confusion

2012-06-30 Thread Ben Widawsky
On Fri, 29 Jun 2012 23:32:16 +0200 Daniel Vetter wrote: > While creating the new enable/disable_gt_powersave functions in > > commit 8090c6b9daa04dda649ac0a2209601042abfb0a4 > Author: Daniel Vetter > Date: Sun Jun 24 16:42:32 2012 +0200 > > drm/i915: wrap up gt powersave enabling functio

Re: [Intel-gfx] [PATCH] drm/i915: fix up ilk rc6 disabling confusion

2012-06-29 Thread Daniel Vetter
On Fri, Jun 29, 2012 at 08:36:14PM -0300, Eugeni Dodonov wrote: > On 06/29/2012 06:32 PM, Daniel Vetter wrote: > > @@ -7270,6 +7270,8 @@ void intel_modeset_cleanup(struct drm_device *dev) > > > > intel_disable_gt_powersave(dev); > > > > + ironlake_teardown_rc6(dev); > > + > > Couldn't we

Re: [Intel-gfx] [PATCH] drm/i915: fix up ilk rc6 disabling confusion

2012-06-29 Thread Eugeni Dodonov
On 06/29/2012 06:32 PM, Daniel Vetter wrote: > @@ -7270,6 +7270,8 @@ void intel_modeset_cleanup(struct drm_device *dev) > > intel_disable_gt_powersave(dev); > > + ironlake_teardown_rc6(dev); > + Couldn't we pass a true/false parameter to the intel_disable_gt_powersave for tearing dow

[Intel-gfx] [PATCH] drm/i915: fix up ilk rc6 disabling confusion

2012-06-29 Thread Daniel Vetter
While creating the new enable/disable_gt_powersave functions in commit 8090c6b9daa04dda649ac0a2209601042abfb0a4 Author: Daniel Vetter Date: Sun Jun 24 16:42:32 2012 +0200 drm/i915: wrap up gt powersave enabling functions I've botched up the handling of ironlake_disable_rc6. Fix this up by