Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-26 Thread Jani Nikula
On Fri, 15 Aug 2014, Paulo Zanoni wrote: > From: Paulo Zanoni > > If we're runtime suspended and try to use the plane interfaces, we > will get a lot of WARNs saying we did the wrong thing. > > We need to get runtime PM references to pin the objects, and to > change the fences. The pin functions

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-18 Thread Ville Syrjälä
On Fri, Aug 15, 2014 at 03:59:32PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > If we're runtime suspended and try to use the plane interfaces, we > will get a lot of WARNs saying we did the wrong thing. > > We need to get runtime PM references to pin the objects, and to > change the fenc

[Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-15 Thread Paulo Zanoni
From: Paulo Zanoni If we're runtime suspended and try to use the plane interfaces, we will get a lot of WARNs saying we did the wrong thing. We need to get runtime PM references to pin the objects, and to change the fences. The pin functions are the ideal places for this, but intel_crtc_cursor_s

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-15 Thread Ville Syrjälä
On Fri, Aug 15, 2014 at 01:47:18PM -0300, Paulo Zanoni wrote: > 2014-08-15 5:39 GMT-03:00 Ville Syrjälä : > > On Thu, Aug 14, 2014 at 12:06:02PM -0300, Paulo Zanoni wrote: > >> From: Paulo Zanoni > >> > >> If we're runtime suspended and try to use the plane interfaces, we > >> will get a lot of WA

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-15 Thread Paulo Zanoni
2014-08-15 5:39 GMT-03:00 Ville Syrjälä : > On Thu, Aug 14, 2014 at 12:06:02PM -0300, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> If we're runtime suspended and try to use the plane interfaces, we >> will get a lot of WARNs saying we did the wrong thing. >> >> We need to get runtime PM referen

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-15 Thread Ville Syrjälä
On Thu, Aug 14, 2014 at 12:06:02PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > If we're runtime suspended and try to use the plane interfaces, we > will get a lot of WARNs saying we did the wrong thing. > > We need to get runtime PM references to pin the objects, and to > change the fenc

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-14 Thread Paulo Zanoni
2014-08-14 12:06 GMT-03:00 Paulo Zanoni : > From: Paulo Zanoni > > If we're runtime suspended and try to use the plane interfaces, we > will get a lot of WARNs saying we did the wrong thing. > > We need to get runtime PM references to pin the objects, and to > change the fences. The pin functions

[Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-14 Thread Paulo Zanoni
From: Paulo Zanoni If we're runtime suspended and try to use the plane interfaces, we will get a lot of WARNs saying we did the wrong thing. We need to get runtime PM references to pin the objects, and to change the fences. The pin functions are the ideal places for this, but intel_crtc_cursor_s

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-13 Thread Daniel Vetter
On Tue, Aug 12, 2014 at 09:51:13PM +0100, Chris Wilson wrote: > On Tue, Aug 12, 2014 at 10:37:21PM +0200, Daniel Vetter wrote: > > On Tue, Aug 12, 2014 at 10:30 PM, Chris Wilson > > wrote: > > > On Tue, Aug 12, 2014 at 10:19:20PM +0200, Daniel Vetter wrote: > > >> On Tue, Aug 12, 2014 at 9:33 PM,

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-12 Thread Chris Wilson
On Tue, Aug 12, 2014 at 10:37:21PM +0200, Daniel Vetter wrote: > On Tue, Aug 12, 2014 at 10:30 PM, Chris Wilson > wrote: > > On Tue, Aug 12, 2014 at 10:19:20PM +0200, Daniel Vetter wrote: > >> On Tue, Aug 12, 2014 at 9:33 PM, Paulo Zanoni wrote: > >> > 2014-08-12 16:28 GMT-03:00 Chris Wilson : >

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-12 Thread Daniel Vetter
On Tue, Aug 12, 2014 at 10:30 PM, Chris Wilson wrote: > On Tue, Aug 12, 2014 at 10:19:20PM +0200, Daniel Vetter wrote: >> On Tue, Aug 12, 2014 at 9:33 PM, Paulo Zanoni wrote: >> > 2014-08-12 16:28 GMT-03:00 Chris Wilson : >> >> On Tue, Aug 12, 2014 at 04:12:38PM -0300, Paulo Zanoni wrote: >> >>>

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-12 Thread Chris Wilson
On Tue, Aug 12, 2014 at 10:19:20PM +0200, Daniel Vetter wrote: > On Tue, Aug 12, 2014 at 9:33 PM, Paulo Zanoni wrote: > > 2014-08-12 16:28 GMT-03:00 Chris Wilson : > >> On Tue, Aug 12, 2014 at 04:12:38PM -0300, Paulo Zanoni wrote: > >>> But we just get/put RPM around this function, not for the who

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-12 Thread Daniel Vetter
On Tue, Aug 12, 2014 at 9:33 PM, Paulo Zanoni wrote: > 2014-08-12 16:28 GMT-03:00 Chris Wilson : >> On Tue, Aug 12, 2014 at 04:12:38PM -0300, Paulo Zanoni wrote: >>> But we just get/put RPM around this function, not for the whole time >>> while the object is pinned. >> >> Ah misread, saw pin->get,

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-12 Thread Paulo Zanoni
2014-08-12 16:28 GMT-03:00 Chris Wilson : > On Tue, Aug 12, 2014 at 04:12:38PM -0300, Paulo Zanoni wrote: >> But we just get/put RPM around this function, not for the whole time >> while the object is pinned. > > Ah misread, saw pin->get, unpin->put and assumed the symmetry. But why > unpin then? I

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-12 Thread Chris Wilson
On Tue, Aug 12, 2014 at 04:12:38PM -0300, Paulo Zanoni wrote: > But we just get/put RPM around this function, not for the whole time > while the object is pinned. Ah misread, saw pin->get, unpin->put and assumed the symmetry. But why unpin then? It doesn't touch any hardware registers. -Chris --

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-12 Thread Paulo Zanoni
2014-08-12 16:09 GMT-03:00 Chris Wilson : > On Tue, Aug 12, 2014 at 03:55:12PM -0300, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> If we're runtime suspended and try to use the plane interfaces, we >> will get a lot of WARNs saying we did the wrong thing. >> >> We need to get runtime PM referen

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-12 Thread Chris Wilson
On Tue, Aug 12, 2014 at 03:55:12PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > If we're runtime suspended and try to use the plane interfaces, we > will get a lot of WARNs saying we did the wrong thing. > > We need to get runtime PM references to pin/unpin the objects, and to > change th

[Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-12 Thread Paulo Zanoni
From: Paulo Zanoni If we're runtime suspended and try to use the plane interfaces, we will get a lot of WARNs saying we did the wrong thing. We need to get runtime PM references to pin/unpin the objects, and to change the fences. The pin/unpin functions are the ideal places for this, but intel_c

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-12 Thread Ville Syrjälä
On Mon, Aug 11, 2014 at 02:57:44PM -0300, Paulo Zanoni wrote: > 2014-08-11 11:42 GMT-03:00 Ville Syrjälä : > > On Mon, Aug 11, 2014 at 11:29:21AM -0300, Paulo Zanoni wrote: > >> 2014-08-11 8:32 GMT-03:00 Ville Syrjälä : > >> > On Wed, Aug 06, 2014 at 06:26:01PM -0300, Paulo Zanoni wrote: > >> >> Fr

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-11 Thread Paulo Zanoni
2014-08-11 11:42 GMT-03:00 Ville Syrjälä : > On Mon, Aug 11, 2014 at 11:29:21AM -0300, Paulo Zanoni wrote: >> 2014-08-11 8:32 GMT-03:00 Ville Syrjälä : >> > On Wed, Aug 06, 2014 at 06:26:01PM -0300, Paulo Zanoni wrote: >> >> From: Paulo Zanoni >> >> >> >> If we're runtime suspended and try to use

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-11 Thread Ville Syrjälä
On Mon, Aug 11, 2014 at 11:29:21AM -0300, Paulo Zanoni wrote: > 2014-08-11 8:32 GMT-03:00 Ville Syrjälä : > > On Wed, Aug 06, 2014 at 06:26:01PM -0300, Paulo Zanoni wrote: > >> From: Paulo Zanoni > >> > >> If we're runtime suspended and try to use the plane interfaces, we > >> will get a lot of WA

[Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-11 Thread Paulo Zanoni
From: Paulo Zanoni If we're runtime suspended and try to use the plane interfaces, we will get a lot of WARNs saying we did the wrong thing. For intel_crtc_update_cursor(), all we need to do is return if the CRTC is not active, since writing the registers won't really have any effect if the scre

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-11 Thread Paulo Zanoni
2014-08-11 8:32 GMT-03:00 Ville Syrjälä : > On Wed, Aug 06, 2014 at 06:26:01PM -0300, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> If we're runtime suspended and try to use the plane interfaces, we >> will get a lot of WARNs saying we did the wrong thing. >> >> For intel_crtc_update_cursor(), a

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-11 Thread Ville Syrjälä
On Wed, Aug 06, 2014 at 06:26:01PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > If we're runtime suspended and try to use the plane interfaces, we > will get a lot of WARNs saying we did the wrong thing. > > For intel_crtc_update_cursor(), all we need to do is return if the > CRTC is not

[Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-06 Thread Paulo Zanoni
From: Paulo Zanoni If we're runtime suspended and try to use the plane interfaces, we will get a lot of WARNs saying we did the wrong thing. For intel_crtc_update_cursor(), all we need to do is return if the CRTC is not active, since writing the registers won't really have any effect if the scre