Re: [Intel-gfx] [PATCH] drm/i915: fix clear mask in GEN7_MISCCPCTL update

2022-10-18 Thread Matt Roper
On Mon, Oct 17, 2022 at 10:55:25AM +0200, Andrzej Hajda wrote: > GEN7_DOP_CLOCK_GATE_ENABLE bit should be cleared, not inverse. > The bug was introduced during conversion to intel_uncore_rmw helper. > > Suggested-by: Matt Roper > Fixes: 8cee664d3eb6f8 ("drm/i915: use proper helper for register up

Re: [Intel-gfx] [PATCH] drm/i915: fix clear mask in GEN7_MISCCPCTL update

2022-10-17 Thread Lucas De Marchi
On Mon, Oct 17, 2022 at 10:22:08AM -0700, Lucas De Marchi wrote: On Mon, Oct 17, 2022 at 10:55:25AM +0200, Andrzej Hajda wrote: GEN7_DOP_CLOCK_GATE_ENABLE bit should be cleared, not inverse. The bug was introduced during conversion to intel_uncore_rmw helper. Suggested-by: Matt Roper Fixes: 8c

Re: [Intel-gfx] [PATCH] drm/i915: fix clear mask in GEN7_MISCCPCTL update

2022-10-17 Thread Lucas De Marchi
On Mon, Oct 17, 2022 at 10:55:25AM +0200, Andrzej Hajda wrote: GEN7_DOP_CLOCK_GATE_ENABLE bit should be cleared, not inverse. The bug was introduced during conversion to intel_uncore_rmw helper. Suggested-by: Matt Roper Fixes: 8cee664d3eb6f8 ("drm/i915: use proper helper for register updates")

[Intel-gfx] [PATCH] drm/i915: fix clear mask in GEN7_MISCCPCTL update

2022-10-17 Thread Andrzej Hajda
GEN7_DOP_CLOCK_GATE_ENABLE bit should be cleared, not inverse. The bug was introduced during conversion to intel_uncore_rmw helper. Suggested-by: Matt Roper Fixes: 8cee664d3eb6f8 ("drm/i915: use proper helper for register updates") Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/i915_irq.