Re: [Intel-gfx] [PATCH] drm/i915: enable vdd when switching off the eDP panel

2012-05-21 Thread Daniel Vetter
On Mon, May 21, 2012 at 06:49:18PM -0700, Keith Packard wrote: > Daniel Vetter writes: > > >> --- a/drivers/gpu/drm/i915/intel_dp.c > >> +++ b/drivers/gpu/drm/i915/intel_dp.c > >> @@ -1154,11 +1154,10 @@ static void ironlake_edp_panel_off(struct intel_dp > >> *intel_dp) > >> > >>DRM_DEBUG_

Re: [Intel-gfx] [PATCH] drm/i915: enable vdd when switching off the eDP panel

2012-05-21 Thread Keith Packard
Daniel Vetter writes: >> --- a/drivers/gpu/drm/i915/intel_dp.c >> +++ b/drivers/gpu/drm/i915/intel_dp.c >> @@ -1154,11 +1154,10 @@ static void ironlake_edp_panel_off(struct intel_dp >> *intel_dp) >> >> DRM_DEBUG_KMS("Turn eDP power off\n"); >> >> -WARN(intel_dp->want_panel_vdd, "Can

Re: [Intel-gfx] [PATCH] drm/i915: enable vdd when switching off the eDP panel

2012-05-21 Thread Chris Wilson
On Mon, 21 May 2012 18:40:30 +0200, Daniel Vetter wrote: > Hi Keith&Chris, > > This is the patch for you to try on the macbook airs Cursory testing of switching on and off the internal panel seems ok. -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: [Intel-gfx] [PATCH] drm/i915: enable vdd when switching off the eDP panel

2012-05-21 Thread Daniel Vetter
Hi Keith&Chris, This is the patch for you to try on the macbook airs Thanks, Daniel On Sun, May 20, 2012 at 05:14:50PM +0200, Daniel Vetter wrote: > We have one bug report from a validation team that we get the eDP > panel sequencing still somewhat wrong: We need to enable VDD while > switc

[Intel-gfx] [PATCH] drm/i915: enable vdd when switching off the eDP panel

2012-05-20 Thread Daniel Vetter
We have one bug report from a validation team that we get the eDP panel sequencing still somewhat wrong: We need to enable VDD while switching off the panel and backlight. Unfortunately that reporter seems to have fallen off the earth :( For another reporter this actually fixes a black panel issue