Re: [Intel-gfx] [PATCH] drm/i915: drop the __i915_active_call pointer packing

2021-05-05 Thread Daniel Vetter
On Tue, May 04, 2021 at 05:41:36PM +0100, Matthew Auld wrote: > We use some of the lower bits of the retire function pointer for > potential flags, which is quite thorny, since the caller needs to > remember to give the function the correct alignment with > __i915_active_call, otherwise we might in

Re: [Intel-gfx] [PATCH] drm/i915: drop the __i915_active_call pointer packing

2021-05-04 Thread Matthew Brost
On Tue, May 04, 2021 at 05:41:36PM +0100, Matthew Auld wrote: > We use some of the lower bits of the retire function pointer for > potential flags, which is quite thorny, since the caller needs to > remember to give the function the correct alignment with > __i915_active_call, otherwise we might in

[Intel-gfx] [PATCH] drm/i915: drop the __i915_active_call pointer packing

2021-05-04 Thread Matthew Auld
We use some of the lower bits of the retire function pointer for potential flags, which is quite thorny, since the caller needs to remember to give the function the correct alignment with __i915_active_call, otherwise we might incorrectly unpack the pointer and jump to some garbage address later. I