Re: [Intel-gfx] [PATCH] drm/i915: dont call irq_put when irq test is on

2013-12-12 Thread Daniel Vetter
On Thu, Dec 12, 2013 at 06:06:16PM +0200, Ville Syrjälä wrote: > On Thu, Dec 12, 2013 at 05:54:42PM +0200, Mika Kuoppala wrote: > > If test is running, irq_get was not called so we should gain > > balance by not doing irq_put > > > > "So the rule is: if you access unlocked values, you use ACCESS_O

Re: [Intel-gfx] [PATCH] drm/i915: dont call irq_put when irq test is on

2013-12-12 Thread Ville Syrjälä
On Thu, Dec 12, 2013 at 05:54:42PM +0200, Mika Kuoppala wrote: > If test is running, irq_get was not called so we should gain > balance by not doing irq_put > > "So the rule is: if you access unlocked values, you use ACCESS_ONCE(). > You don't say "but it can't matter". Because you simply don't kn

[Intel-gfx] [PATCH] drm/i915: dont call irq_put when irq test is on

2013-12-12 Thread Mika Kuoppala
If test is running, irq_get was not called so we should gain balance by not doing irq_put "So the rule is: if you access unlocked values, you use ACCESS_ONCE(). You don't say "but it can't matter". Because you simply don't know." -- Linus v2: use local variable so it can't change during test (Chr

Re: [Intel-gfx] [PATCH] drm/i915: dont call irq_put when irq test is on

2013-12-12 Thread Ville Syrjälä
On Mon, Dec 09, 2013 at 08:47:22PM +0200, Mika Kuoppala wrote: > If test is running, irq_get was not called so we should > gain balance by not doing irq_put > > v2: use local variable so it can't change during test (Chris) > > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_gem.c

[Intel-gfx] [PATCH] drm/i915: dont call irq_put when irq test is on

2013-12-09 Thread Mika Kuoppala
If test is running, irq_get was not called so we should gain balance by not doing irq_put v2: use local variable so it can't change during test (Chris) Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/