Re: [Intel-gfx] [PATCH] drm/i915: don't update the dri1 breadcrumb with modesetting

2013-12-11 Thread Eugene Shatokhin
On 12/11/2013 03:06 PM, Daniel Vetter wrote: On Tue, Dec 10, 2013 at 02:48:23PM +0100, Daniel Vetter wrote: On Tue, Dec 10, 2013 at 12:44:12PM +, Chris Wilson wrote: On Tue, Dec 10, 2013 at 01:24:01PM +0100, Daniel Vetter wrote: The update is horribly racy since it doesn't protect at all a

Re: [Intel-gfx] [PATCH] drm/i915: don't update the dri1 breadcrumb with modesetting

2013-12-11 Thread Daniel Vetter
On Tue, Dec 10, 2013 at 02:48:23PM +0100, Daniel Vetter wrote: > On Tue, Dec 10, 2013 at 12:44:12PM +, Chris Wilson wrote: > > On Tue, Dec 10, 2013 at 01:24:01PM +0100, Daniel Vetter wrote: > > > The update is horribly racy since it doesn't protect at all against > > > concurrent closing of the

Re: [Intel-gfx] [PATCH] drm/i915: don't update the dri1 breadcrumb with modesetting

2013-12-10 Thread Daniel Vetter
On Tue, Dec 10, 2013 at 12:44:12PM +, Chris Wilson wrote: > On Tue, Dec 10, 2013 at 01:24:01PM +0100, Daniel Vetter wrote: > > The update is horribly racy since it doesn't protect at all against > > concurrent closing of the master fd. And it can't really since that > > requires us to grab a mu

Re: [Intel-gfx] [PATCH] drm/i915: don't update the dri1 breadcrumb with modesetting

2013-12-10 Thread Chris Wilson
On Tue, Dec 10, 2013 at 01:24:01PM +0100, Daniel Vetter wrote: > The update is horribly racy since it doesn't protect at all against > concurrent closing of the master fd. And it can't really since that > requires us to grab a mutex. > > Instead of jumping through hoops and offloading this to a wo

[Intel-gfx] [PATCH] drm/i915: don't update the dri1 breadcrumb with modesetting

2013-12-10 Thread Daniel Vetter
The update is horribly racy since it doesn't protect at all against concurrent closing of the master fd. And it can't really since that requires us to grab a mutex. Instead of jumping through hoops and offloading this to a worker thread just block this bit of code for the modesetting driver. Repo