Re: [Intel-gfx] [PATCH] drm/i915: don't leak global_timeline

2016-11-17 Thread Chris Wilson
On Thu, Nov 17, 2016 at 08:38:07PM +, Matthew Auld wrote: > We need to clean up the global_timeline in i915_gem_load_cleanup. > > v2: don't forget about the struct_mutex, and also WARN_ON if we have any > remaining timelines before purging the global_timeline. > > v3: it might be a good idea

[Intel-gfx] [PATCH] drm/i915: don't leak global_timeline

2016-11-17 Thread Matthew Auld
We need to clean up the global_timeline in i915_gem_load_cleanup. v2: don't forget about the struct_mutex, and also WARN_ON if we have any remaining timelines before purging the global_timeline. v3: it might be a good idea to first remove the global_timeline...duh! Fixes: 73cb97010d4f ("drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: don't leak global_timeline

2016-11-17 Thread Chris Wilson
On Thu, Nov 17, 2016 at 08:20:05PM +, Matthew Auld wrote: > We need to clean up the global_timeline in i915_gem_load_cleanup. > > v2: don't forget about the struct_mutex, and also WARN_ON if we have any > remaining timelines before purging the global_timeline. > > Fixes: 73cb97010d4f ("drm/i9

[Intel-gfx] [PATCH] drm/i915: don't leak global_timeline

2016-11-17 Thread Matthew Auld
We need to clean up the global_timeline in i915_gem_load_cleanup. v2: don't forget about the struct_mutex, and also WARN_ON if we have any remaining timelines before purging the global_timeline. Fixes: 73cb97010d4f ("drm/i915: Combine seqno + tracking into a global timeline struct") Cc: Chris Wi

Re: [Intel-gfx] [PATCH] drm/i915: don't leak global_timeline

2016-11-17 Thread Chris Wilson
On Thu, Nov 17, 2016 at 09:48:18AM +0100, Daniel Vetter wrote: > On Wed, Nov 16, 2016 at 07:32:49PM +, Matthew Auld wrote: > > We need to clean up the global_timeline in i915_gem_load_cleanup. > > > > Cc: Chris Wilson > > Signed-off-by: Matthew Auld > > Fixes: line probably missing? And why

Re: [Intel-gfx] [PATCH] drm/i915: don't leak global_timeline

2016-11-17 Thread Daniel Vetter
On Wed, Nov 16, 2016 at 07:32:49PM +, Matthew Auld wrote: > We need to clean up the global_timeline in i915_gem_load_cleanup. > > Cc: Chris Wilson > Signed-off-by: Matthew Auld Fixes: line probably missing? And why was that not caught when the original patch landed? -Daniel > --- > driver

Re: [Intel-gfx] [PATCH] drm/i915: don't leak global_timeline

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 07:32:49PM +, Matthew Auld wrote: > We need to clean up the global_timeline in i915_gem_load_cleanup. > > Cc: Chris Wilson > Signed-off-by: Matthew Auld > --- > drivers/gpu/drm/i915/i915_gem.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/dr

[Intel-gfx] [PATCH] drm/i915: don't leak global_timeline

2016-11-16 Thread Matthew Auld
We need to clean up the global_timeline in i915_gem_load_cleanup. Cc: Chris Wilson Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 3fb5e66..c440e72 10064