Re: [Intel-gfx] [PATCH] drm/i915: don't double-restore ARB mode bits for kms

2014-02-05 Thread Daniel Vetter
On Wed, Feb 5, 2014 at 2:01 PM, Jani Nikula wrote: > On Thu, 16 Jan 2014, Daniel Vetter wrote: >> On Thu, Jan 16, 2014 at 5:54 PM, Paulo Zanoni wrote: >>> 2014/1/16 Daniel Vetter : Our init_clock_gating functions and related code should already take care of this. And if they don't we'd

Re: [Intel-gfx] [PATCH] drm/i915: don't double-restore ARB mode bits for kms

2014-02-05 Thread Jani Nikula
On Thu, 16 Jan 2014, Daniel Vetter wrote: > On Thu, Jan 16, 2014 at 5:54 PM, Paulo Zanoni wrote: >> 2014/1/16 Daniel Vetter : >>> Our init_clock_gating functions and related code should already take >>> care of this. And if they don't we'd better know. >> >> For both registers, I see functions ap

Re: [Intel-gfx] [PATCH] drm/i915: don't double-restore ARB mode bits for kms

2014-01-16 Thread Daniel Vetter
On Thu, Jan 16, 2014 at 5:54 PM, Paulo Zanoni wrote: > 2014/1/16 Daniel Vetter : >> Our init_clock_gating functions and related code should already take >> care of this. And if they don't we'd better know. > > For both registers, I see functions applying specific workarounds, but > they only do th

Re: [Intel-gfx] [PATCH] drm/i915: don't double-restore ARB mode bits for kms

2014-01-16 Thread Paulo Zanoni
2014/1/16 Daniel Vetter : > Our init_clock_gating functions and related code should already take > care of this. And if they don't we'd better know. For both registers, I see functions applying specific workarounds, but they only do the read-write-modify through _MASKED_BIT_ENABLE(). I don't see a

[Intel-gfx] [PATCH] drm/i915: don't double-restore ARB mode bits for kms

2014-01-16 Thread Daniel Vetter
Our init_clock_gating functions and related code should already take care of this. And if they don't we'd better know. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_suspend.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/gpu