Re: [Intel-gfx] [PATCH] drm/i915: don't disable disconnected outputs

2012-12-18 Thread Daniel Vetter
On Tue, Dec 18, 2012 at 08:56:33AM -0800, Jesse Barnes wrote: > On Tue, 18 Dec 2012 09:37:54 +0100 > Daniel Vetter wrote: > > > This piece of neat lore has been ported painstakingly and bug-for-bug > > compatible from the old crtc helper code. > > > > Imo it's utter nonsense. > > > > If you dis

Re: [Intel-gfx] [PATCH] drm/i915: don't disable disconnected outputs

2012-12-18 Thread Jesse Barnes
On Tue, 18 Dec 2012 09:37:54 +0100 Daniel Vetter wrote: > This piece of neat lore has been ported painstakingly and bug-for-bug > compatible from the old crtc helper code. > > Imo it's utter nonsense. > > If you disconnected a cable and before you reconnect it, userspace (or > the kernel) does

Re: [Intel-gfx] [PATCH] drm/i915: don't disable disconnected outputs

2012-12-18 Thread Rodrigo Vivi
makes sense Reviewed-by: Rodrigo Vivi couldn't we close the bug already? On Tue, Dec 18, 2012 at 6:37 AM, Daniel Vetter wrote: > This piece of neat lore has been ported painstakingly and bug-for-bug > compatible from the old crtc helper code. > > Imo it's utter nonsense. > > If you disconnected

[Intel-gfx] [PATCH] drm/i915: don't disable disconnected outputs

2012-12-18 Thread Daniel Vetter
This piece of neat lore has been ported painstakingly and bug-for-bug compatible from the old crtc helper code. Imo it's utter nonsense. If you disconnected a cable and before you reconnect it, userspace (or the kernel) does an set_crtc call, this will result in that connector getting disabled. W

Re: [Intel-gfx] [PATCH] drm/i915: don't disable disconnected outputs

2012-10-12 Thread Daniel Vetter
On Fri, Oct 12, 2012 at 11:02 AM, Chris Wilson wrote: > On Thu, 11 Oct 2012 19:46:27 +0200, Daniel Vetter > wrote: >> This piece of neat lore has been ported painstakingly and bug-for-bug >> compatible from the old crtc helper code. >> >> Imo it's utter nonsense. >> >> If you have disconnect a c

Re: [Intel-gfx] [PATCH] drm/i915: don't disable disconnected outputs

2012-10-12 Thread Chris Wilson
On Thu, 11 Oct 2012 19:46:27 +0200, Daniel Vetter wrote: > This piece of neat lore has been ported painstakingly and bug-for-bug > compatible from the old crtc helper code. > > Imo it's utter nonsense. > > If you have disconnect a cable and before you reconnect it, userspace > (or the kernel) d

[Intel-gfx] [PATCH] drm/i915: don't disable disconnected outputs

2012-10-11 Thread Daniel Vetter
This piece of neat lore has been ported painstakingly and bug-for-bug compatible from the old crtc helper code. Imo it's utter nonsense. If you have disconnect a cable and before you reconnect it, userspace (or the kernel) does an set_crtc call, this will result in that connector getting disable.