Re: [Intel-gfx] [PATCH] drm/i915: disable IPS while getting the sink CRCs

2015-05-28 Thread Daniel Vetter
On Wed, May 27, 2015 at 04:42:08PM -0300, Paulo Zanoni wrote: > 2015-05-27 16:35 GMT-03:00 Rodrigo Vivi : > > I didn't face this since I was letting IPS disabled on my tests here > > and the platforms that I'm mostly concerned about sink CRC not working > > well are the ones that doesn't have IPS.

Re: [Intel-gfx] [PATCH] drm/i915: disable IPS while getting the sink CRCs

2015-05-27 Thread Rodrigo Vivi
On Wed, May 27, 2015 at 1:14 PM, Paulo Zanoni wrote: > 2015-05-27 17:06 GMT-03:00 Rodrigo Vivi : >> On Wed, May 27, 2015 at 12:42 PM, Paulo Zanoni wrote: >>> 2015-05-27 16:35 GMT-03:00 Rodrigo Vivi : I didn't face this since I was letting IPS disabled on my tests here and the platforms

Re: [Intel-gfx] [PATCH] drm/i915: disable IPS while getting the sink CRCs

2015-05-27 Thread Paulo Zanoni
2015-05-27 17:06 GMT-03:00 Rodrigo Vivi : > On Wed, May 27, 2015 at 12:42 PM, Paulo Zanoni wrote: >> 2015-05-27 16:35 GMT-03:00 Rodrigo Vivi : >>> I didn't face this since I was letting IPS disabled on my tests here >>> and the platforms that I'm mostly concerned about sink CRC not working >>> wel

Re: [Intel-gfx] [PATCH] drm/i915: disable IPS while getting the sink CRCs

2015-05-27 Thread Rodrigo Vivi
On Wed, May 27, 2015 at 12:42 PM, Paulo Zanoni wrote: > 2015-05-27 16:35 GMT-03:00 Rodrigo Vivi : >> I didn't face this since I was letting IPS disabled on my tests here >> and the platforms that I'm mostly concerned about sink CRC not working >> well are the ones that doesn't have IPS. >> >> I'm

Re: [Intel-gfx] [PATCH] drm/i915: disable IPS while getting the sink CRCs

2015-05-27 Thread Paulo Zanoni
2015-05-27 16:35 GMT-03:00 Rodrigo Vivi : > I didn't face this since I was letting IPS disabled on my tests here > and the platforms that I'm mostly concerned about sink CRC not working > well are the ones that doesn't have IPS. > > I'm not sure this is the right way to solve this issue. Maybe we w

Re: [Intel-gfx] [PATCH] drm/i915: disable IPS while getting the sink CRCs

2015-05-27 Thread Rodrigo Vivi
I didn't face this since I was letting IPS disabled on my tests here and the platforms that I'm mostly concerned about sink CRC not working well are the ones that doesn't have IPS. I'm not sure this is the right way to solve this issue. Maybe we want to know the sink CRC when IPS is on. I believe

[Intel-gfx] [PATCH] drm/i915: disable IPS while getting the sink CRCs

2015-05-25 Thread Paulo Zanoni
From: Paulo Zanoni This commit is the "sink CRC" version of: commit 8c740dcea254a1472df2c0ac5ac585412a2507ec Author: Paulo Zanoni Date: Fri Oct 17 18:42:03 2014 -0300 drm/i915: disable IPS while getting the pipe CRCs. For some unknown reason, when IPS gets enabled, the sink CRC changes.