Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-08-18 Thread Stéphane Marchesin
On Fri, Aug 18, 2017 at 2:07 AM, Jani Nikula wrote: > On Thu, 17 Aug 2017, Stéphane Marchesin wrote: >> On Mon, Jun 19, 2017 at 11:45 AM, Jani Nikula >> wrote: >>> >>> On Thu, 15 Jun 2017, Imre Deak wrote: >>> > On Thu, Jun 15, 2017 at 10:20:57AM -0700, Rodrigo Vivi wrote: >>> >> I believe it i

Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-08-18 Thread Chris Wilson
Quoting Tahvanainen, Jari (2017-08-18 15:26:03) > " Do we have a bug about this at bugs.freedesktop.org?" I did quick query on > fdo.bugzilla and did not find any matching item (afaik) from there (with > i915_feature = GPU *hang*|*DMC*) so I would claim that bug is not filed. > Stephane can corr

Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-08-18 Thread Tahvanainen, Jari
--Original Message- From: Jani Nikula [mailto:jani.nik...@linux.intel.com] Sent: Friday, August 18, 2017 12:08 PM To: Stéphane Marchesin Cc: Deak, Imre ; Rodrigo Vivi ; intel-gfx@lists.freedesktop.org; Matt Atwood ; Saarinen, Jani ; Tahvanainen, Jari Subject: Re: [Intel-gfx] [PATCH] drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-08-18 Thread Jani Nikula
On Thu, 17 Aug 2017, Stéphane Marchesin wrote: > On Mon, Jun 19, 2017 at 11:45 AM, Jani Nikula > wrote: >> >> On Thu, 15 Jun 2017, Imre Deak wrote: >> > On Thu, Jun 15, 2017 at 10:20:57AM -0700, Rodrigo Vivi wrote: >> >> I believe it is worth allowing RPM to work without requiring DMC, no?! >> >

Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-08-17 Thread Stéphane Marchesin
On Mon, Jun 19, 2017 at 11:45 AM, Jani Nikula wrote: > > On Thu, 15 Jun 2017, Imre Deak wrote: > > On Thu, Jun 15, 2017 at 10:20:57AM -0700, Rodrigo Vivi wrote: > >> I believe it is worth allowing RPM to work without requiring DMC, no?! > > > > Not if there is no good reason for not using DMC. It

Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-06-19 Thread Jani Nikula
On Thu, 15 Jun 2017, Imre Deak wrote: > On Thu, Jun 15, 2017 at 10:20:57AM -0700, Rodrigo Vivi wrote: >> I believe it is worth allowing RPM to work without requiring DMC, no?! > > Not if there is no good reason for not using DMC. It was decided early > on that we won't support that configuration s

Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-06-15 Thread Imre Deak
;> is saved when RPM is turned on with DMC missing vs both turned off, So > >> i think D3 is definitely relevant even without DMC. > >> > >> From: Deak, Imre > >> Sent: Wednesday, June 14, 2017 1:17 PM > >> To: Rodrigo Vivi > >> Cc: Atwood, Matthew S; inte

Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-06-15 Thread Rodrigo Vivi
both turned off, So >> i think D3 is definitely relevant even without DMC. >> >> From: Deak, Imre >> Sent: Wednesday, June 14, 2017 1:17 PM >> To: Rodrigo Vivi >> Cc: Atwood, Matthew S; intel-gfx@lists.freedesktop.org; marc...@google.com; >

Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-06-15 Thread Imre Deak
ng you need to enable DC6/9 for > that. I'm not even sure if it's even valid to enter PCI D3 without > enabling these states first. And for that you need the firmware. > > > > > > > > >> > > >> From: D

Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-06-15 Thread Atwood, Matthew S
ithout DMC. From: Deak, Imre Sent: Wednesday, June 14, 2017 1:17 PM To: Rodrigo Vivi Cc: Atwood, Matthew S; intel-gfx@lists.freedesktop.org; marc...@google.com; Matt Atwood Subject: Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence On Wed, Jun 14, 2017 at

Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-06-14 Thread Imre Deak
> >> From: Deak, Imre > >> Sent: Wednesday, June 14, 2017 10:33 AM > >> To: Atwood, Matthew S > >> Cc: intel-gfx@lists.freedesktop.org; marc...@google.com; Matt Atwood > >> Subject: Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement &

Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-06-14 Thread Atwood, Matthew S
From: Rodrigo Vivi [rodrigo.v...@gmail.com] Sent: Wednesday, June 14, 2017 1:02 PM To: Deak, Imre Cc: Atwood, Matthew S; intel-gfx@lists.freedesktop.org; marc...@google.com; Matt Atwood Subject: Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence On W

Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-06-14 Thread Rodrigo Vivi
> There is no reason to support that configuration. What if someone doesn't really want to use DMC but still wants D3hot? > >> >> From: Deak, Imre >> Sent: Wednesday, June 14, 2017 10:33 AM >> To: Atwood, Matthew

Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-06-14 Thread Imre Deak
ednesday, June 14, 2017 10:33 AM > To: Atwood, Matthew S > Cc: intel-gfx@lists.freedesktop.org; marc...@google.com; Matt Atwood > Subject: Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement > from DMC presence > > On Wed, Jun 14, 2017 at 10:12:21AM -0700, matthew.s.atw

Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-06-14 Thread Atwood, Matthew S
t DMC loaded we want to keep runtime PM disabled" - Why? From: Deak, Imre Sent: Wednesday, June 14, 2017 10:33 AM To: Atwood, Matthew S Cc: intel-gfx@lists.freedesktop.org; marc...@google.com; Matt Atwood Subject: Re: [Intel-gfx] [PATCH] drm/i915: decoup

Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-06-14 Thread Imre Deak
On Wed, Jun 14, 2017 at 10:12:21AM -0700, matthew.s.atw...@intel.com wrote: > From: Matt Atwood > > Runtime PM is disabled when DMC firmware is not present. Runtime PM is still > enabled even if DMC firmware fails to load. Hm, that would be a bug, but I can't see how it can happen; could you exp

[Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

2017-06-14 Thread matthew . s . atwood
From: Matt Atwood Runtime PM is disabled when DMC firmware is not present. Runtime PM is still enabled even if DMC firmware fails to load. This patch enables runtime PM to be enabled if DMC firmware is not present. Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/intel_csr.c | 7 +++ 1