Re: [Intel-gfx] [PATCH] drm/i915: consolidate and tighten encoder cloning checks

2013-06-05 Thread Daniel Vetter
On Thu, May 30, 2013 at 03:04:25PM +0200, Daniel Vetter wrote: > Only lvds/tv did actually check for cloning or not, but many more > places should. > > Notices because my ivb tried to enable both cpu edp and vga on the > first crtc - the resulting confusion between has_pch_encoder, > has_dp_encode

[Intel-gfx] [PATCH] drm/i915: consolidate and tighten encoder cloning checks

2013-05-30 Thread Daniel Vetter
Only lvds/tv did actually check for cloning or not, but many more places should. Notices because my ivb tried to enable both cpu edp and vga on the first crtc - the resulting confusion between has_pch_encoder, has_dp_encoder but not actually being a pch dp encoder resulting in hilarity (hitting a

[Intel-gfx] [PATCH] drm/i915: consolidate and tighten encoder cloning checks

2013-05-29 Thread Daniel Vetter
Only lvds/tv did actually check for cloning or not, but many more places should. Notices because my ivb tried to enable both cpu edp and vga on the first crtc - the resulting confusion between has_pch_encoder, has_dp_encoder but not actually being a pch dp encoder resulting in hilarity (hitting a