Subject: Re: [Intel-gfx] [PATCH] drm/i915: cleanup patch for intel_ddi.c
On Thu, Mar 09, 2017 at 04:28:20PM +0530, Shashank Sharma wrote:
> In I915 driver, there are many places where variable name for
> intel_encoder object is given as 'intel_encoder' whereas it would make
> more s
On Thu, Mar 09, 2017 at 04:28:20PM +0530, Shashank Sharma wrote:
> In I915 driver, there are many places where variable name for
> intel_encoder object is given as 'intel_encoder' whereas it would
> make more sense in many places to call it just 'encoder'.
>
> This patch does a similar cleanup in
The summary should say what the clean up is about. For example:
drm/i915: Remove intel_ prefix from encoder variables in intel_ddi.c
With that fixed,
Reviewed-by: Ander Conselvan de Oliveira
On Thu, 2017-03-09 at 16:28 +0530, Shashank Sharma wrote:
> In I915 driver, there are many places where
On Thu, 09 Mar 2017, Shashank Sharma wrote:
> In I915 driver, there are many places where variable name for
> intel_encoder object is given as 'intel_encoder' whereas it would
> make more sense in many places to call it just 'encoder'.
>
> This patch does a similar cleanup in file intel_ddi.c.
>
>
In I915 driver, there are many places where variable name for
intel_encoder object is given as 'intel_encoder' whereas it would
make more sense in many places to call it just 'encoder'.
This patch does a similar cleanup in file intel_ddi.c.
PS: There are few functions where both drm_encoder and i