Re: [Intel-gfx] [PATCH] drm/i915: cleanup lrc engine state when lrc is freed

2015-01-20 Thread Mika Kuoppala
Ville Syrjälä writes: > On Fri, Jan 09, 2015 at 06:47:41PM +, Dave Gordon wrote: >> On 08/01/15 13:40, Mika Kuoppala wrote: >> > i915_gem_validate_context() will check the engine->state to see if it can >> > submit into a ringbuffer. But when we are releasing the context we leave >> > the >>

Re: [Intel-gfx] [PATCH] drm/i915: cleanup lrc engine state when lrc is freed

2015-01-12 Thread Ville Syrjälä
On Fri, Jan 09, 2015 at 06:47:41PM +, Dave Gordon wrote: > On 08/01/15 13:40, Mika Kuoppala wrote: > > i915_gem_validate_context() will check the engine->state to see if it can > > submit into a ringbuffer. But when we are releasing the context we leave the > > engine state to a non null value.

Re: [Intel-gfx] [PATCH] drm/i915: cleanup lrc engine state when lrc is freed

2015-01-09 Thread Dave Gordon
On 08/01/15 13:40, Mika Kuoppala wrote: > i915_gem_validate_context() will check the engine->state to see if it can > submit into a ringbuffer. But when we are releasing the context we leave the > engine state to a non null value. Thus after a successful hang recovery > we might mistakenly submit t

Re: [Intel-gfx] [PATCH] drm/i915: cleanup lrc engine state when lrc is freed

2015-01-08 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV -32 363/364

[Intel-gfx] [PATCH] drm/i915: cleanup lrc engine state when lrc is freed

2015-01-08 Thread Mika Kuoppala
i915_gem_validate_context() will check the engine->state to see if it can submit into a ringbuffer. But when we are releasing the context we leave the engine state to a non null value. Thus after a successful hang recovery we might mistakenly submit to a non initialized ringbuffer resulting in: [