[Intel-gfx] [PATCH] drm/i915: blitter ring workaround for gen6

2011-10-03 Thread Ben Widawsky
I found this workaround in the docs while trying to debug a certain test case I stumbled upon. The patch is in flux as I try to get it to be useful. Both my test case and xscreensaver slip have similar scenarios which I'm hoping some variation of this patch will fix. Again, this doesn't fix anyth

Re: [Intel-gfx] [PATCH] drm/i915: blitter ring workaround for gen6

2011-10-03 Thread Ben Widawsky
On Mon, 3 Oct 2011 09:41:28 +0200 Daniel Vetter wrote: > On Sun, Oct 02, 2011 at 06:27:12PM -0700, Ben Widawsky wrote: > > Found this through doc inspection. I don't have a failing test case that > > this > > fixes, but the docs specify we need to do it in addition to the A0 > > workaround. >

[Intel-gfx] [PATCH] drm/i915: blitter ring workaround for gen6

2011-10-03 Thread Ben Widawsky
I found this workaround in the docs while trying to debug a certain test case I stumbled upon. The patch is in flux as I try to get it to be useful. Both my test case and xscreensaver slip have similar scenarios which I'm hoping some variation of this patch will fix. Again, this doesn't fix anythi

Re: [Intel-gfx] [PATCH] drm/i915: blitter ring workaround for gen6

2011-10-03 Thread Daniel Vetter
On Sun, Oct 02, 2011 at 06:27:12PM -0700, Ben Widawsky wrote: > Found this through doc inspection. I don't have a failing test case that this > fixes, but the docs specify we need to do it in addition to the A0 workaround. Can you confirm that the A0 workaround is really needed in addition to this

Re: [Intel-gfx] [PATCH] drm/i915: blitter ring workaround for gen6

2011-10-03 Thread Chris Wilson
On Sun, 2 Oct 2011 18:27:12 -0700, Ben Widawsky wrote: > Found this through doc inspection. I don't have a failing test case that this > fixes, but the docs specify we need to do it in addition to the A0 workaround. Can you try running /usr/lib/xscreenaver/xslip with and without this patch? That

Re: [Intel-gfx] [PATCH] drm/i915: blitter ring workaround for gen6

2011-10-02 Thread Ben Widawsky
On Sun, Oct 02, 2011 at 09:20:32PM -0700, Keith Packard wrote: > On Sun, 2 Oct 2011 18:27:12 -0700, Ben Widawsky wrote: > > > +static void blt_ring_begin2(struct intel_ring_buffer *ring) > > +{ > > + if (!ring->private) > > + return; > > + > > + intel_ring_emit(ring, MI_LOAD_REGIST

Re: [Intel-gfx] [PATCH] drm/i915: blitter ring workaround for gen6

2011-10-02 Thread Keith Packard
On Sun, 2 Oct 2011 18:27:12 -0700, Ben Widawsky wrote: > +static void blt_ring_begin2(struct intel_ring_buffer *ring) > +{ > + if (!ring->private) > + return; > + > + intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1)); > + intel_ring_emit(ring, 0x2209c); > + intel_ring_em

[Intel-gfx] [PATCH] drm/i915: blitter ring workaround for gen6

2011-10-02 Thread Ben Widawsky
Found this through doc inspection. I don't have a failing test case that this fixes, but the docs specify we need to do it in addition to the A0 workaround. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/intel_ringbuffer.c | 58 +-- 1 files changed, 55 inserti