Re: [Intel-gfx] [PATCH] drm/i915: always set FDI composite sync bit

2011-10-11 Thread Jesse Barnes
On Tue, 11 Oct 2011 12:42:22 -0400 Adam Jackson wrote: > On 10/11/11 12:16 PM, Jesse Barnes wrote: > > On Tue, 11 Oct 2011 10:10:24 -0400 Adam Jackson wrote: > >> It still seems entirely magical and probably wrong in some situations. > >> And I'm thrilled to see that PPT is functionally differen

Re: [Intel-gfx] [PATCH] drm/i915: always set FDI composite sync bit

2011-10-11 Thread Adam Jackson
On 10/11/11 12:16 PM, Jesse Barnes wrote: On Tue, 11 Oct 2011 10:10:24 -0400 Adam Jackson wrote: It still seems entirely magical and probably wrong in some situations. And I'm thrilled to see that PPT is functionally different from CPT (seriously, stop doing that) instead of just moving bit def

Re: [Intel-gfx] [PATCH] drm/i915: always set FDI composite sync bit

2011-10-11 Thread Keith Packard
On Tue, 11 Oct 2011 09:40:18 -0700, Jesse Barnes wrote: > Ok just got confirmation that always setting the composite bit is safe > on IVB per the specs we provide to board designers (i.e. they're > required to make composite sync work, and fsync/lsync is optional). Thanks. That sounds conclusiv

Re: [Intel-gfx] [PATCH] drm/i915: always set FDI composite sync bit

2011-10-11 Thread Jesse Barnes
On Tue, 11 Oct 2011 10:10:24 -0400 Adam Jackson wrote: > On 10/10/11 7:22 PM, Keith Packard wrote: > > On Mon, 10 Oct 2011 14:28:52 -0700, Jesse Barnes > > wrote: > > > >> It's needed for 3 pipe support as well as just regular functionality > >> (e.g. DisplayPort). > > > > Any explanation on ho

Re: [Intel-gfx] [PATCH] drm/i915: always set FDI composite sync bit

2011-10-11 Thread Jesse Barnes
On Tue, 11 Oct 2011 10:10:24 -0400 Adam Jackson wrote: > On 10/10/11 7:22 PM, Keith Packard wrote: > > On Mon, 10 Oct 2011 14:28:52 -0700, Jesse Barnes > > wrote: > > > >> It's needed for 3 pipe support as well as just regular functionality > >> (e.g. DisplayPort). > > > > Any explanation on ho

Re: [Intel-gfx] [PATCH] drm/i915: always set FDI composite sync bit

2011-10-11 Thread Adam Jackson
On 10/10/11 7:22 PM, Keith Packard wrote: On Mon, 10 Oct 2011 14:28:52 -0700, Jesse Barnes wrote: It's needed for 3 pipe support as well as just regular functionality (e.g. DisplayPort). Any explanation on how you get sync without this? As in, why did this ever work? To a first approximat

Re: [Intel-gfx] [PATCH] drm/i915: always set FDI composite sync bit

2011-10-10 Thread Keith Packard
On Mon, 10 Oct 2011 14:28:52 -0700, Jesse Barnes wrote: > It's needed for 3 pipe support as well as just regular functionality > (e.g. DisplayPort). Any explanation on how you get sync without this? As in, why did this ever work? -- keith.pack...@intel.com pgpiiHwV2DslA.pgp Description: PGP

Re: [Intel-gfx] [PATCH] drm/i915: always set FDI composite sync bit

2011-10-10 Thread Eugeni Dodonov
On Mon, Oct 10, 2011 at 18:28, Jesse Barnes wrote: > It's needed for 3 pipe support as well as just regular functionality > (e.g. DisplayPort). > > Signed-off-by: Jesse Barnes > Tested-by: Eugeni Dodonov -- Eugeni Dodonov __

Re: [Intel-gfx] [PATCH] drm/i915: always set FDI composite sync bit

2011-10-10 Thread Adam Jackson
On Mon, 2011-10-10 at 14:28 -0700, Jesse Barnes wrote: > It's needed for 3 pipe support as well as just regular functionality > (e.g. DisplayPort). > > Signed-off-by: Jesse Barnes Tested-by: Adam Jackson - ajax signature.asc Description: This is a digitally signed message part __

[Intel-gfx] [PATCH] drm/i915: always set FDI composite sync bit

2011-10-10 Thread Jesse Barnes
It's needed for 3 pipe support as well as just regular functionality (e.g. DisplayPort). Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_reg.h |1 + drivers/gpu/drm/i915/intel_display.c |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i