Re: [Intel-gfx] [PATCH] drm/i915: add register read IOCTL

2012-07-12 Thread Ben Widawsky
On Thu, 12 Jul 2012 12:42:30 -0700 Eric Anholt wrote: > Ben Widawsky writes: > > > The interface's immediate purpose is to do synchronous timestamp queries > > as required by GL_TIMESTAMP. The GPU has a register for reading the > > timestamp but because that would normally require root access,

Re: [Intel-gfx] [PATCH] drm/i915: add register read IOCTL

2012-07-12 Thread Eric Anholt
Ben Widawsky writes: > The interface's immediate purpose is to do synchronous timestamp queries > as required by GL_TIMESTAMP. The GPU has a register for reading the > timestamp but because that would normally require root access, the > IOCTL can provide this service. > > Currently the implementa

Re: [Intel-gfx] [PATCH] drm/i915: add register read IOCTL

2012-07-12 Thread Chris Wilson
On Thu, 12 Jul 2012 09:58:43 +0200, Daniel Vetter wrote: > On Wed, Jul 11, 2012 at 05:07:36PM -0700, Ben Widawsky wrote: > I think we should check for both reg offset _and_ size. Just to avoid > people reading 64bit for a 32bit reg to get at the secret stuff in the > next reg ;-) Or in case that t

Re: [Intel-gfx] [PATCH] drm/i915: add register read IOCTL

2012-07-12 Thread Daniel Vetter
On Wed, Jul 11, 2012 at 05:07:36PM -0700, Ben Widawsky wrote: > The interface's immediate purpose is to do synchronous timestamp queries > as required by GL_TIMESTAMP. The GPU has a register for reading the > timestamp but because that would normally require root access, the > IOCTL can provide thi

[Intel-gfx] [PATCH] drm/i915: add register read IOCTL

2012-07-11 Thread Ben Widawsky
The interface's immediate purpose is to do synchronous timestamp queries as required by GL_TIMESTAMP. The GPU has a register for reading the timestamp but because that would normally require root access, the IOCTL can provide this service. Currently the implementation whitelists only the render ri