Re: [Intel-gfx] [PATCH] drm/i915: add psr toggle to debugfs

2015-04-20 Thread Rodrigo Vivi
On Mon, Apr 20, 2015 at 8:41 AM, Daniel Vetter wrote: > On Thu, Apr 16, 2015 at 09:10:11AM -0700, Eric Caruso wrote: >> On Thu, Apr 16, 2015 at 8:58 AM, Rodrigo Vivi wrote: >> > I'm not sure that that property will be accepted... >> > if so it can be changed to toggle, but for now it is informati

Re: [Intel-gfx] [PATCH] drm/i915: add psr toggle to debugfs

2015-04-20 Thread Daniel Vetter
On Thu, Apr 16, 2015 at 09:10:11AM -0700, Eric Caruso wrote: > On Thu, Apr 16, 2015 at 8:58 AM, Rodrigo Vivi wrote: > > I'm not sure that that property will be accepted... > > if so it can be changed to toggle, but for now it is informative only > > (DRM_MODE_PROP_IMMUTABLE). > > > > Okay, that c

Re: [Intel-gfx] [PATCH] drm/i915: add psr toggle to debugfs

2015-04-16 Thread Eric Caruso
On Thu, Apr 16, 2015 at 8:58 AM, Rodrigo Vivi wrote: > I'm not sure that that property will be accepted... > if so it can be changed to toggle, but for now it is informative only > (DRM_MODE_PROP_IMMUTABLE). > Okay, that changes things somewhat. There'll have to be some discussion over what the s

Re: [Intel-gfx] [PATCH] drm/i915: add psr toggle to debugfs

2015-04-16 Thread Rodrigo Vivi
I'm not sure that that property will be accepted... if so it can be changed to toggle, but for now it is informative only (DRM_MODE_PROP_IMMUTABLE). On Wed, Apr 15, 2015 at 2:51 PM, Eric Caruso wrote: > On Wed, Apr 15, 2015 at 2:39 PM, Rodrigo Vivi wrote: >> On Fri, Mar 13, 2015 at 1:46 PM, Eri

Re: [Intel-gfx] [PATCH] drm/i915: add psr toggle to debugfs

2015-04-15 Thread Eric Caruso
On Wed, Apr 15, 2015 at 2:39 PM, Rodrigo Vivi wrote: > On Fri, Mar 13, 2015 at 1:46 PM, Eric Caruso wrote: >> On Fri, Mar 13, 2015 at 1:14 PM, Paulo Zanoni wrote: >>> 2015-03-13 16:01 GMT-03:00 Daniel Vetter : On Fri, Mar 13, 2015 at 7:10 PM, Eric Caruso wrote: > This patch allows user

Re: [Intel-gfx] [PATCH] drm/i915: add psr toggle to debugfs

2015-04-15 Thread Rodrigo Vivi
On Fri, Mar 13, 2015 at 1:46 PM, Eric Caruso wrote: > On Fri, Mar 13, 2015 at 1:14 PM, Paulo Zanoni wrote: >> 2015-03-13 16:01 GMT-03:00 Daniel Vetter : >>> On Fri, Mar 13, 2015 at 7:10 PM, Eric Caruso wrote: This patch allows userspace to toggle PSR through a debugfs interface. It add

Re: [Intel-gfx] [PATCH] drm/i915: add psr toggle to debugfs

2015-03-13 Thread Eric Caruso
On Fri, Mar 13, 2015 at 1:14 PM, Paulo Zanoni wrote: > 2015-03-13 16:01 GMT-03:00 Daniel Vetter : >> On Fri, Mar 13, 2015 at 7:10 PM, Eric Caruso wrote: >>> This patch allows userspace to toggle PSR through a debugfs interface. >>> It adds functionality to write 0 or 1 to the existing >>> i915_ed

Re: [Intel-gfx] [PATCH] drm/i915: add psr toggle to debugfs

2015-03-13 Thread Paulo Zanoni
2015-03-13 16:01 GMT-03:00 Daniel Vetter : > On Fri, Mar 13, 2015 at 7:10 PM, Eric Caruso wrote: >> This patch allows userspace to toggle PSR through a debugfs interface. >> It adds functionality to write 0 or 1 to the existing >> i915_edp_psr_status file in order to change the relevant module >>

Re: [Intel-gfx] [PATCH] drm/i915: add psr toggle to debugfs

2015-03-13 Thread Daniel Vetter
On Fri, Mar 13, 2015 at 7:10 PM, Eric Caruso wrote: > This patch allows userspace to toggle PSR through a debugfs interface. > It adds functionality to write 0 or 1 to the existing > i915_edp_psr_status file in order to change the relevant module > parameter and enable/disable PSR. > > Previous up

[Intel-gfx] [PATCH] drm/i915: add psr toggle to debugfs

2015-03-13 Thread Eric Caruso
This patch allows userspace to toggle PSR through a debugfs interface. It adds functionality to write 0 or 1 to the existing i915_edp_psr_status file in order to change the relevant module parameter and enable/disable PSR. Previous upstream feedback did not like making it a connector property or p