The i915 driver checks for color management properties changes as part
of a plane update. Therefore a color management update must imply a
plane update, otherwise we never update the transformation matrixes
and degamma/gamma LUTs.
v2: add comment about moving the commit of color management registe
The i915 driver checks for color management properties changes as part
of a plane update. Therefore a color management update must imply a
plane update, otherwise we never update the transformation matrixes
and degamma/gamma LUTs.
v2: add comment about moving the commit of color management registe
On Thu, May 12, 2016 at 11:31:16AM +0100, Lionel Landwerlin wrote:
> Hey Daniel,
>
> Sorry to nag again. Could you cherry pick this?
In some earlier review (seems to have been lost, at least you didn't
reply) I suggested you just set planes_changed when computing color mgm
differences. That mail
Hey Daniel,
Sorry to nag again. Could you cherry pick this?
Thanks!
-
Lionel
On 11/05/16 11:51, Maarten Lankhorst wrote:
Op 09-05-16 om 16:40 schreef Lionel Landwerlin:
We are currently missing the color management update condition to
commit planes on crtc.
v2: add comment about moving the
Op 09-05-16 om 16:40 schreef Lionel Landwerlin:
> We are currently missing the color management update condition to
> commit planes on crtc.
>
> v2: add comment about moving the commit of color management registers
> to an async worker
>
> v3: Commit color management register right after vblank
We are currently missing the color management update condition to
commit planes on crtc.
v2: add comment about moving the commit of color management registers
to an async worker
v3: Commit color management register right after vblank
v4: Move back color management commit condition together w
On Fri, May 06, 2016 at 01:52:58PM +0300, Ville Syrjälä wrote:
> On Thu, May 05, 2016 at 03:04:54PM +0100, Lionel Landwerlin wrote:
> > On 04/05/16 15:30, Ville Syrjälä wrote:
> > > On Wed, May 04, 2016 at 02:40:34PM +0100, Lionel Landwerlin wrote:
> > >> We are currently missing the color manageme
On Wed, May 04, 2016 at 12:13:39PM +0100, Lionel Landwerlin wrote:
> We are currently missing the color management update condition to
> commit planes on crtc.
>
> v2: add comment about moving the commit of color management registers
> to an async worker
>
> Fixes: 20a34e78f0d7 (drm/i915: Upd
On Thu, May 05, 2016 at 03:04:54PM +0100, Lionel Landwerlin wrote:
> On 04/05/16 15:30, Ville Syrjälä wrote:
> > On Wed, May 04, 2016 at 02:40:34PM +0100, Lionel Landwerlin wrote:
> >> We are currently missing the color management update condition to
> >> commit planes on crtc.
> >>
> >> v2: add co
On 04/05/16 15:30, Ville Syrjälä wrote:
On Wed, May 04, 2016 at 02:40:34PM +0100, Lionel Landwerlin wrote:
We are currently missing the color management update condition to
commit planes on crtc.
v2: add comment about moving the commit of color management registers
to an async worker
v3:
On Wed, May 04, 2016 at 02:40:34PM +0100, Lionel Landwerlin wrote:
> We are currently missing the color management update condition to
> commit planes on crtc.
>
> v2: add comment about moving the commit of color management registers
> to an async worker
>
> v3: Commit color management regist
We are currently missing the color management update condition to
commit planes on crtc.
v2: add comment about moving the commit of color management registers
to an async worker
v3: Commit color management register right after vblank
Fixes: 20a34e78f0d7 (drm/i915: Update color management dur
On Wed, May 04, 2016 at 11:25:12AM +0100, Lionel Landwerlin wrote:
> On 21/04/16 14:57, Ville Syrjälä wrote:
> > On Thu, Apr 21, 2016 at 03:30:09PM +0200, Maarten Lankhorst wrote:
> >> Hey,
> >>
> >> Op 18-04-16 om 13:05 schreef Lionel Landwerlin:
> >>> Ping?
> >>>
> >> Will commit, but looks like
Op 04-05-16 om 12:25 schreef Lionel Landwerlin:
> On 21/04/16 14:57, Ville Syrjälä wrote:
>> On Thu, Apr 21, 2016 at 03:30:09PM +0200, Maarten Lankhorst wrote:
>>> Hey,
>>>
>>> Op 18-04-16 om 13:05 schreef Lionel Landwerlin:
Ping?
>>> Will commit, but looks like Ville made a comment about
We are currently missing the color management update condition to
commit planes on crtc.
v2: add comment about moving the commit of color management registers
to an async worker
Fixes: 20a34e78f0d7 (drm/i915: Update color management during vblank evasion.)
Cc: Maarten Lankhorst
Cc: Jani Niku
On 21/04/16 14:57, Ville Syrjälä wrote:
On Thu, Apr 21, 2016 at 03:30:09PM +0200, Maarten Lankhorst wrote:
Hey,
Op 18-04-16 om 13:05 schreef Lionel Landwerlin:
Ping?
Will commit, but looks like Ville made a comment about double buffering.
Everything in intel_pipe_update_start depends on dou
On Thu, Apr 21, 2016 at 03:30:09PM +0200, Maarten Lankhorst wrote:
> Hey,
>
> Op 18-04-16 om 13:05 schreef Lionel Landwerlin:
> > Ping?
> >
> Will commit, but looks like Ville made a comment about double buffering.
>
> Everything in intel_pipe_update_start depends on double buffering, so if the
Hey,
Op 18-04-16 om 13:05 schreef Lionel Landwerlin:
> Ping?
>
Will commit, but looks like Ville made a comment about double buffering.
Everything in intel_pipe_update_start depends on double buffering, so if the
lut isn't then it probably has to be done either before or afterwards. Not sure
wh
On Fri, Apr 08, 2016 at 05:30:40PM +0100, Lionel Landwerlin wrote:
> We are currently missing the color management update condition to
> commit planes on crtc.
On a related note, could you move the LUT stuff out from the critical
section? It has no business being there since the registers aren't
d
Op 08-04-16 om 18:30 schreef Lionel Landwerlin:
> We are currently missing the color management update condition to
> commit planes on crtc.
>
> Fixes: 20a34e78f0d7 (drm/i915: Update color management during vblank evasion.)
> Cc: Maarten Lankhorst
> Cc: Jani Nikula
> Cc: Daniel Vetter
> Signed-o
Ping?
On 08/04/16 17:30, Lionel Landwerlin wrote:
We are currently missing the color management update condition to
commit planes on crtc.
Fixes: 20a34e78f0d7 (drm/i915: Update color management during vblank evasion.)
Cc: Maarten Lankhorst
Cc: Jani Nikula
Cc: Daniel Vetter
Signed-off-by: Lio
We are currently missing the color management update condition to
commit planes on crtc.
Fixes: 20a34e78f0d7 (drm/i915: Update color management during vblank evasion.)
Cc: Maarten Lankhorst
Cc: Jani Nikula
Cc: Daniel Vetter
Signed-off-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/intel_displ
22 matches
Mail list logo
