Re: [Intel-gfx] [PATCH] drm/i915: add energy counter support for IVB

2012-06-20 Thread Eugeni Dodonov
On 06/20/2012 12:59 PM, Daniel Vetter wrote: > On Wed, Jun 20, 2012 at 5:53 PM, Chris Wilson > wrote: >> On Wed, 20 Jun 2012 08:32:59 -0700, Jesse Barnes >> wrote: >>> On Wed, 20 Jun 2012 09:38:25 +0200 >>> Daniel Vetter wrote: And from the bikeshed departement: Can't we just print a runn

Re: [Intel-gfx] [PATCH] drm/i915: add energy counter support for IVB

2012-06-20 Thread Daniel Vetter
On Wed, Jun 20, 2012 at 5:53 PM, Chris Wilson wrote: > On Wed, 20 Jun 2012 08:32:59 -0700, Jesse Barnes > wrote: >> On Wed, 20 Jun 2012 09:38:25 +0200 >> Daniel Vetter wrote: >> > And from the bikeshed departement: Can't we just print a running number? I >> > know, substraction is bloody hard,

Re: [Intel-gfx] [PATCH] drm/i915: add energy counter support for IVB

2012-06-20 Thread Chris Wilson
On Wed, 20 Jun 2012 08:32:59 -0700, Jesse Barnes wrote: > On Wed, 20 Jun 2012 09:38:25 +0200 > Daniel Vetter wrote: > > And from the bikeshed departement: Can't we just print a running number? I > > know, substraction is bloody hard, but for anything else than total power > > consumption (e.g. g

Re: [Intel-gfx] [PATCH] drm/i915: add energy counter support for IVB

2012-06-20 Thread Jesse Barnes
On Wed, 20 Jun 2012 09:38:25 +0200 Daniel Vetter wrote: > On Wed, Jun 20, 2012 at 09:20:39AM +0300, Jani Nikula wrote: > > On Tue, 19 Jun 2012, Jesse Barnes wrote: > > > On SNB and IVB, there's an MSR (also exposed through MCHBAR) we can use > > > to read out the amount of energy used over time.

Re: [Intel-gfx] [PATCH] drm/i915: add energy counter support for IVB

2012-06-20 Thread Daniel Vetter
On Wed, Jun 20, 2012 at 09:20:39AM +0300, Jani Nikula wrote: > On Tue, 19 Jun 2012, Jesse Barnes wrote: > > On SNB and IVB, there's an MSR (also exposed through MCHBAR) we can use > > to read out the amount of energy used over time. Expose this in debugfs > > to make it easy to do power compariso

Re: [Intel-gfx] [PATCH] drm/i915: add energy counter support for IVB

2012-06-20 Thread Jani Nikula
On Tue, 19 Jun 2012, Jesse Barnes wrote: > On SNB and IVB, there's an MSR (also exposed through MCHBAR) we can use > to read out the amount of energy used over time. Expose this in debugfs > to make it easy to do power comparisons with different configurations. > > Signed-off-by: Jesse Barnes >

Re: [Intel-gfx] [PATCH] drm/i915: add energy counter support for IVB

2012-06-19 Thread Ben Widawsky
On Tue, 19 Jun 2012 17:59:13 -0700 Jesse Barnes wrote: > Ben Widawsky wrote: > > >On Tue, 19 Jun 2012 13:20:50 -0700 > >Jesse Barnes wrote: > > > >> On SNB and IVB, there's an MSR (also exposed through MCHBAR) we can > >use > >> to read out the amount of energy used over time. Expose this in

Re: [Intel-gfx] [PATCH] drm/i915: add energy counter support for IVB

2012-06-19 Thread Jesse Barnes
Ben Widawsky wrote: >On Tue, 19 Jun 2012 13:20:50 -0700 >Jesse Barnes wrote: > >> On SNB and IVB, there's an MSR (also exposed through MCHBAR) we can >use >> to read out the amount of energy used over time. Expose this in >debugfs >> to make it easy to do power comparisons with different >confi

Re: [Intel-gfx] [PATCH] drm/i915: add energy counter support for IVB

2012-06-19 Thread Ben Widawsky
On Tue, 19 Jun 2012 13:20:50 -0700 Jesse Barnes wrote: > On SNB and IVB, there's an MSR (also exposed through MCHBAR) we can use > to read out the amount of energy used over time. Expose this in debugfs > to make it easy to do power comparisons with different configurations. I'd like some more

[Intel-gfx] [PATCH] drm/i915: add energy counter support for IVB

2012-06-19 Thread Jesse Barnes
On SNB and IVB, there's an MSR (also exposed through MCHBAR) we can use to read out the amount of energy used over time. Expose this in debugfs to make it easy to do power comparisons with different configurations. Signed-off-by: Jesse Barnes diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/