Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-03 Thread Daniel Vetter
On Sat, Sep 01, 2012 at 07:44:17PM -0700, Arjan van de Ven wrote: > On 9/1/2012 6:36 PM, Ben Widawsky wrote: > > > It depends on what you're trying to measure. I think this patch is quite > > useful but I think I'll make you defend your patch now since you're the > > maintainer and you took > >

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-03 Thread Daniel Vetter
On Sat, Sep 01, 2012 at 06:36:32PM -0700, Ben Widawsky wrote: > On 2012-09-01 12:14, Daniel Vetter wrote: > >On Sat, Sep 1, 2012 at 8:35 PM, Ben Widawsky > >wrote: > >>On 2012-09-01 11:28, Arjan van de Ven wrote: > >>> > >>>On 9/1/2012 11:26 AM, Ben Widawsky wrote: > > On 2012-08-30 04:26

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-02 Thread Chris Wilson
On Sat, 01 Sep 2012 18:16:52 -0700, Ben Widawsky wrote: > On 2012-09-01 12:22, Chris Wilson wrote: > > On Sat, 01 Sep 2012 11:35:13 -0700, Ben Widawsky > > wrote: > >> I have no problem with Daniel's patch. It's just a matter of cutting > >> through some scheduler BS of "when the GPU wants to ch

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Ben Widawsky
On 2012-09-01 20:06, Arjan van de Ven wrote: On 9/1/2012 8:05 PM, Ben Widawsky wrote: , from a single trace event you should know the current frequency and the previous frequency. but if you're doing a heavy game or whatever... you may stay at the highest all the time, and I get no information.

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Ben Widawsky
On 2012-09-01 19:44, Arjan van de Ven wrote: On 9/1/2012 6:36 PM, Ben Widawsky wrote: It depends on what you're trying to measure. I think this patch is quite useful but I think I'll make you defend your patch now since you're the maintainer and you took your own patch and you're shooting down

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Ben Widawsky
On 2012-09-01 12:14, Daniel Vetter wrote: On Sat, Sep 1, 2012 at 8:35 PM, Ben Widawsky wrote: On 2012-09-01 11:28, Arjan van de Ven wrote: On 9/1/2012 11:26 AM, Ben Widawsky wrote: On 2012-08-30 04:26, Daniel Vetter wrote: We've had and still have too many issues where the gpu turbot doe

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Ben Widawsky
On 2012-09-01 12:22, Chris Wilson wrote: On Sat, 01 Sep 2012 11:35:13 -0700, Ben Widawsky wrote: I have no problem with Daniel's patch. It's just a matter of cutting through some scheduler BS of "when the GPU wants to change frequency" vs. "when we actually change the GPU frequency." I think

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Chris Wilson
On Sat, 01 Sep 2012 11:35:13 -0700, Ben Widawsky wrote: > I have no problem with Daniel's patch. It's just a matter of cutting > through some scheduler BS of "when the GPU wants to change frequency" > vs. "when we actually change the GPU frequency." I think *both* are > interesting. We already

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Daniel Vetter
On Sat, Sep 1, 2012 at 8:35 PM, Ben Widawsky wrote: > On 2012-09-01 11:28, Arjan van de Ven wrote: >> >> On 9/1/2012 11:26 AM, Ben Widawsky wrote: >>> >>> On 2012-08-30 04:26, Daniel Vetter wrote: We've had and still have too many issues where the gpu turbot doesn't quite to what it

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Ben Widawsky
On 2012-09-01 11:28, Arjan van de Ven wrote: On 9/1/2012 11:26 AM, Ben Widawsky wrote: On 2012-08-30 04:26, Daniel Vetter wrote: We've had and still have too many issues where the gpu turbot doesn't quite to what it's supposed to do (or what we want it to do). Adding a tracepoint to track whe

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Ben Widawsky
On 2012-08-30 04:26, Daniel Vetter wrote: We've had and still have too many issues where the gpu turbot doesn't quite to what it's supposed to do (or what we want it to do). Adding a tracepoint to track when the desired gpu frequence changes should help a lot in characterizing and understanding

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-08-31 Thread Daniel Vetter
On Thu, Aug 30, 2012 at 02:34:11PM +0100, Chris Wilson wrote: > On Thu, 30 Aug 2012 13:26:48 +0200, Daniel Vetter > wrote: > > We've had and still have too many issues where the gpu turbot doesn't > > quite to what it's supposed to do (or what we want it to do). > > > > Adding a tracepoint to tr

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-08-30 Thread Paul Menzel
Am Donnerstag, den 30.08.2012, 13:26 +0200 schrieb Daniel Vetter: > We've had and still have too many issues where the gpu turbot doesn't s,turbot,turbo, > quite to what it's supposed to do (or what we want it to do). s,to,do, > Adding a tracepoint to track when the desired gpu frequence change

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-08-30 Thread Chris Wilson
On Thu, 30 Aug 2012 13:26:48 +0200, Daniel Vetter wrote: > We've had and still have too many issues where the gpu turbot doesn't > quite to what it's supposed to do (or what we want it to do). > > Adding a tracepoint to track when the desired gpu frequence changes > should help a lot in characte

[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-08-30 Thread Daniel Vetter
We've had and still have too many issues where the gpu turbot doesn't quite to what it's supposed to do (or what we want it to do). Adding a tracepoint to track when the desired gpu frequence changes should help a lot in characterizing and understanding problematic workloads. Also, this should be