Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-24 Thread Mika Kahola
On Fri, 2018-04-20 at 13:56 -0700, Dhinakaran Pandiyan wrote: > On Fri, 2018-04-20 at 11:15 -0700, Rodrigo Vivi wrote: > > > > On Thu, Apr 19, 2018 at 10:03:05AM +0300, Mika Kahola wrote: > > > > > > On Thu, 2018-04-19 at 09:11 +0300, Lofstedt, Marta wrote: > > > > > > > > For the PW results:  >

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-24 Thread Jani Nikula
On Mon, 23 Apr 2018, Dhinakaran Pandiyan wrote: > On Fri, 2018-04-20 at 14:15 +0300, Mika Kahola wrote: >> On Fri, 2018-04-20 at 11:22 +0300, Jani Nikula wrote: >> > On Fri, 20 Apr 2018, Mika Kahola wrote: >> > > >> > > On Thu, 2018-04-19 at 17:09 +0300, Jani Nikula wrote: >> > > > >> > > > On

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-23 Thread Rodrigo Vivi
On Mon, Apr 23, 2018 at 01:24:39PM -0700, Dhinakaran Pandiyan wrote: > > > > On Mon, 2018-04-23 at 12:34 -0700, Rodrigo Vivi wrote: > > On Mon, Apr 23, 2018 at 12:21:39PM -0700, Dhinakaran Pandiyan wrote: > > > > > > > > > > > > On Fri, 2018-04-20 at 14:15 +0300, Mika Kahola wrote: > > > > On

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-23 Thread Dhinakaran Pandiyan
On Mon, 2018-04-23 at 12:34 -0700, Rodrigo Vivi wrote: > On Mon, Apr 23, 2018 at 12:21:39PM -0700, Dhinakaran Pandiyan wrote: > > > > > > > > On Fri, 2018-04-20 at 14:15 +0300, Mika Kahola wrote: > > > On Fri, 2018-04-20 at 11:22 +0300, Jani Nikula wrote: > > > > On Fri, 20 Apr 2018, Mika Kah

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-23 Thread Rodrigo Vivi
On Mon, Apr 23, 2018 at 12:21:39PM -0700, Dhinakaran Pandiyan wrote: > > > > On Fri, 2018-04-20 at 14:15 +0300, Mika Kahola wrote: > > On Fri, 2018-04-20 at 11:22 +0300, Jani Nikula wrote: > > > On Fri, 20 Apr 2018, Mika Kahola wrote: > > > > > > > > On Thu, 2018-04-19 at 17:09 +0300, Jani Nik

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-23 Thread Dhinakaran Pandiyan
On Fri, 2018-04-20 at 14:15 +0300, Mika Kahola wrote: > On Fri, 2018-04-20 at 11:22 +0300, Jani Nikula wrote: > > On Fri, 20 Apr 2018, Mika Kahola wrote: > > > > > > On Thu, 2018-04-19 at 17:09 +0300, Jani Nikula wrote: > > > > > > > > On Wed, 18 Apr 2018, Mika Kahola wrote: > > > > > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-20 Thread Dhinakaran Pandiyan
On Fri, 2018-04-20 at 11:15 -0700, Rodrigo Vivi wrote: > On Thu, Apr 19, 2018 at 10:03:05AM +0300, Mika Kahola wrote: > > On Thu, 2018-04-19 at 09:11 +0300, Lofstedt, Marta wrote: > > > For the PW results: > > > https://patchwork.freedesktop.org/series/41877/ > > > > > > it didn't fix the CRC mis

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-20 Thread Rodrigo Vivi
will be able to kill this sink crc code entirely > > > > > > > > > > > -Original Message- > > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On > > > Behalf > > > Of Mika Kahola > > > Sent: Wed

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-20 Thread Mika Kahola
On Fri, 2018-04-20 at 11:22 +0300, Jani Nikula wrote: > On Fri, 20 Apr 2018, Mika Kahola wrote: > > > > On Thu, 2018-04-19 at 17:09 +0300, Jani Nikula wrote: > > > > > > On Wed, 18 Apr 2018, Mika Kahola wrote: > > > > > > > > > > > > When reading out CRC's we  wait for a vblank on > > > > int

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-20 Thread Jani Nikula
On Fri, 20 Apr 2018, Mika Kahola wrote: > On Thu, 2018-04-19 at 17:09 +0300, Jani Nikula wrote: >> On Wed, 18 Apr 2018, Mika Kahola wrote: >> > >> > When reading out CRC's we  wait for a vblank on >> > intel_dp_sink_crc_start() >> > function. When we start reading out CRC's in intel_dp_sink_crc(

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-19 Thread Mika Kahola
On Thu, 2018-04-19 at 17:09 +0300, Jani Nikula wrote: > On Wed, 18 Apr 2018, Mika Kahola wrote: > > > > When reading out CRC's we  wait for a vblank on > > intel_dp_sink_crc_start() > > function. When we start reading out CRC's in intel_dp_sink_crc() > > loop we > > first wait for a vblank yieldi

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-19 Thread Jani Nikula
On Wed, 18 Apr 2018, Mika Kahola wrote: > When reading out CRC's we wait for a vblank on intel_dp_sink_crc_start() > function. When we start reading out CRC's in intel_dp_sink_crc() loop we > first wait for a vblank yielding that all in all we end up waiting two > vblanks on the first iteration r

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-19 Thread Mika Kahola
on't know if it was intentional. I'll try to find out why it was needed. > > > > > > -Original Message- > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On > > Behalf > > Of Mika Kahola > > Sent: Wednesday, April 18, 2018 10:57 AM > > To:

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-18 Thread Lofstedt, Marta
-Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > Of Mika Kahola > Sent: Wednesday, April 18, 2018 10:57 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read >

[Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-18 Thread Mika Kahola
When reading out CRC's we wait for a vblank on intel_dp_sink_crc_start() function. When we start reading out CRC's in intel_dp_sink_crc() loop we first wait for a vblank yielding that all in all we end up waiting two vblanks on the first iteration round. Therefore, let's move the intel_wait_for_vb