Re: [Intel-gfx] [PATCH] drm/i915: Verify the engine after acquiring the active.lock

2019-09-18 Thread Tvrtko Ursulin
On 18/09/2019 17:10, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-09-18 16:54:36) On 17/09/2019 16:17, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-09-17 15:59:25) On 16/09/2019 12:38, Chris Wilson wrote: When using virtual engines, the rq->engine is not stable until we hold the en

Re: [Intel-gfx] [PATCH] drm/i915: Verify the engine after acquiring the active.lock

2019-09-18 Thread Chris Wilson
Quoting Chris Wilson (2019-09-18 17:10:26) > Quoting Tvrtko Ursulin (2019-09-18 16:54:36) > > > > On 17/09/2019 16:17, Chris Wilson wrote: > > > Quoting Tvrtko Ursulin (2019-09-17 15:59:25) > > >> > > >> On 16/09/2019 12:38, Chris Wilson wrote: > > >>> When using virtual engines, the rq->engine is

Re: [Intel-gfx] [PATCH] drm/i915: Verify the engine after acquiring the active.lock

2019-09-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-09-18 16:54:36) > > On 17/09/2019 16:17, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-09-17 15:59:25) > >> > >> On 16/09/2019 12:38, Chris Wilson wrote: > >>> When using virtual engines, the rq->engine is not stable until we hold > >>> the engine->active.lock (

Re: [Intel-gfx] [PATCH] drm/i915: Verify the engine after acquiring the active.lock

2019-09-18 Thread Tvrtko Ursulin
On 17/09/2019 16:17, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-09-17 15:59:25) On 16/09/2019 12:38, Chris Wilson wrote: When using virtual engines, the rq->engine is not stable until we hold the engine->active.lock (as the virtual engine may be exchanged with the sibling). Since commit

Re: [Intel-gfx] [PATCH] drm/i915: Verify the engine after acquiring the active.lock

2019-09-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-09-17 15:59:25) > > On 16/09/2019 12:38, Chris Wilson wrote: > > When using virtual engines, the rq->engine is not stable until we hold > > the engine->active.lock (as the virtual engine may be exchanged with the > > sibling). Since commit 22b7a426bbe1 ("drm/i915/execl

Re: [Intel-gfx] [PATCH] drm/i915: Verify the engine after acquiring the active.lock

2019-09-17 Thread Tvrtko Ursulin
On 16/09/2019 12:38, Chris Wilson wrote: When using virtual engines, the rq->engine is not stable until we hold the engine->active.lock (as the virtual engine may be exchanged with the sibling). Since commit 22b7a426bbe1 ("drm/i915/execlists: Preempt-to-busy") we may retire a request concurrentl

[Intel-gfx] [PATCH] drm/i915: Verify the engine after acquiring the active.lock

2019-09-16 Thread Chris Wilson
When using virtual engines, the rq->engine is not stable until we hold the engine->active.lock (as the virtual engine may be exchanged with the sibling). Since commit 22b7a426bbe1 ("drm/i915/execlists: Preempt-to-busy") we may retire a request concurrently with resubmitting it to HW, we need to be