Re: [Intel-gfx] [PATCH] drm/i915: Use unsigned long for obj->user_pin_count

2013-10-10 Thread Chris Wilson
On Thu, Oct 10, 2013 at 02:46:37PM +0200, Daniel Vetter wrote: > At least on linux sizeof(long) == sizeof(void*) and the thinking > is that you can grab about as many references as there's memory. > > Doesn't really matter, just a bit of OCD since the fixed size data > type in a pure in-kernel dat

[Intel-gfx] [PATCH] drm/i915: Use unsigned long for obj->user_pin_count

2013-10-10 Thread Daniel Vetter
At least on linux sizeof(long) == sizeof(void*) and the thinking is that you can grab about as many references as there's memory. Doesn't really matter, just a bit of OCD since the fixed size data type in a pure in-kernel datastructure look off. v2: Ville asked for an overflow check since no one

Re: [Intel-gfx] [PATCH] drm/i915: Use unsigned long for obj->user_pin_count

2013-10-10 Thread Chris Wilson
On Thu, Oct 10, 2013 at 01:29:37PM +0200, Daniel Vetter wrote: > At least on linux sizeof(long) == sizeof(void*) and the thinking > is that you can grab about as many references as there's memory. > > Doesn't really matter, just a bit of OCD since the fixed size data > type in a pure in-kernel dat

[Intel-gfx] [PATCH] drm/i915: Use unsigned long for obj->user_pin_count

2013-10-10 Thread Daniel Vetter
At least on linux sizeof(long) == sizeof(void*) and the thinking is that you can grab about as many references as there's memory. Doesn't really matter, just a bit of OCD since the fixed size data type in a pure in-kernel datastructure look off. v2: Ville asked for an overflow check since no one