Re: [Intel-gfx] [PATCH] drm/i915: Use ktime on wait_for

2018-04-24 Thread Mika Kuoppala
Imre Deak writes: > On Fri, Apr 20, 2018 at 11:27:55AM +0100, Chris Wilson wrote: >> Quoting Mika Kuoppala (2018-04-20 10:54:26) >> > We use jiffies to determine when wait expires. However >> > Imre did find out that jiffies can and will do a >1 >> > increments on certain situations [1]. When thi

Re: [Intel-gfx] [PATCH] drm/i915: Use ktime on wait_for

2018-04-20 Thread Imre Deak
On Fri, Apr 20, 2018 at 11:27:55AM +0100, Chris Wilson wrote: > Quoting Mika Kuoppala (2018-04-20 10:54:26) > > We use jiffies to determine when wait expires. However > > Imre did find out that jiffies can and will do a >1 > > increments on certain situations [1]. When this happens > > in a wait_fo

Re: [Intel-gfx] [PATCH] drm/i915: Use ktime on wait_for

2018-04-20 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Sagar Arun Kamble (2018-04-20 11:23:50) >> >> >> On 4/20/2018 3:24 PM, Mika Kuoppala wrote: >> > We use jiffies to determine when wait expires. However >> > Imre did find out that jiffies can and will do a >1 >> > increments on certain situations [1]. When this ha

Re: [Intel-gfx] [PATCH] drm/i915: Use ktime on wait_for

2018-04-20 Thread Sagar Arun Kamble
On 4/20/2018 4:09 PM, Chris Wilson wrote: Quoting Sagar Arun Kamble (2018-04-20 11:23:50) On 4/20/2018 3:24 PM, Mika Kuoppala wrote: We use jiffies to determine when wait expires. However Imre did find out that jiffies can and will do a >1 increments on certain situations [1]. When this happ

Re: [Intel-gfx] [PATCH] drm/i915: Use ktime on wait_for

2018-04-20 Thread Chris Wilson
Quoting Sagar Arun Kamble (2018-04-20 11:23:50) > > > On 4/20/2018 3:24 PM, Mika Kuoppala wrote: > > We use jiffies to determine when wait expires. However > > Imre did find out that jiffies can and will do a >1 > > increments on certain situations [1]. When this happens > > in a wait_for loop, w

Re: [Intel-gfx] [PATCH] drm/i915: Use ktime on wait_for

2018-04-20 Thread Chris Wilson
Quoting Mika Kuoppala (2018-04-20 10:54:26) > We use jiffies to determine when wait expires. However > Imre did find out that jiffies can and will do a >1 > increments on certain situations [1]. When this happens > in a wait_for loop, we return timeout errorneously > much earlier than what the real

Re: [Intel-gfx] [PATCH] drm/i915: Use ktime on wait_for

2018-04-20 Thread Sagar Arun Kamble
On 4/20/2018 3:24 PM, Mika Kuoppala wrote: We use jiffies to determine when wait expires. However Imre did find out that jiffies can and will do a >1 increments on certain situations [1]. When this happens in a wait_for loop, we return timeout errorneously much earlier than what the real wallcl

[Intel-gfx] [PATCH] drm/i915: Use ktime on wait_for

2018-04-20 Thread Mika Kuoppala
We use jiffies to determine when wait expires. However Imre did find out that jiffies can and will do a >1 increments on certain situations [1]. When this happens in a wait_for loop, we return timeout errorneously much earlier than what the real wallclock would say. We can't afford our waits to ti