Re: [Intel-gfx] [PATCH] drm/i915: Use a global lock for modifying global irq flags

2012-04-25 Thread Daniel Vetter
On Tue, Apr 24, 2012 at 02:05:25PM -0700, Ben Widawsky wrote: > On Tue, 24 Apr 2012 21:48:47 +0100 > Chris Wilson wrote: > > > We were attempting to use a per-ring spinlock whilst modifying global > > IRQ flags. A recipe for rare missed interrupts. > > > > Signed-off-by: Chris Wilson > > Regar

Re: [Intel-gfx] [PATCH] drm/i915: Use a global lock for modifying global irq flags

2012-04-24 Thread Ben Widawsky
On Tue, 24 Apr 2012 21:48:47 +0100 Chris Wilson wrote: > We were attempting to use a per-ring spinlock whilst modifying global > IRQ flags. A recipe for rare missed interrupts. > > Signed-off-by: Chris Wilson Regardless of whether or not this currently fixes anything, I need this for an upcomi

[Intel-gfx] [PATCH] drm/i915: Use a global lock for modifying global irq flags

2012-04-24 Thread Chris Wilson
We were attempting to use a per-ring spinlock whilst modifying global IRQ flags. A recipe for rare missed interrupts. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 41 ++- drivers/gpu/drm/i915/intel_ringbuffer.h |3 +-- 2 files change