Re: [Intel-gfx] [PATCH] drm/i915: Use POSTING_READ in lcpll code

2013-08-22 Thread Daniel Vetter
On Wed, Aug 21, 2013 at 06:49:31PM -0300, Paulo Zanoni wrote: > 2013/8/21 Daniel Vetter : > > If we don't use the return value of a mmio read our coding style is to > > use the POSTING_READ macro. This avoids cluttering the mmio traces. > > > > While at it add the missing posting read in the lcpll

Re: [Intel-gfx] [PATCH] drm/i915: Use POSTING_READ in lcpll code

2013-08-21 Thread Paulo Zanoni
2013/8/21 Daniel Vetter : > If we don't use the return value of a mmio read our coding style is to > use the POSTING_READ macro. This avoids cluttering the mmio traces. > > While at it add the missing posting read in the lcpll enable function > that Paulo spotted. > > v2: Drop the _NOTRACE changes,

[Intel-gfx] [PATCH] drm/i915: Use POSTING_READ in lcpll code

2013-08-21 Thread Daniel Vetter
If we don't use the return value of a mmio read our coding style is to use the POSTING_READ macro. This avoids cluttering the mmio traces. While at it add the missing posting read in the lcpll enable function that Paulo spotted. v2: Drop the _NOTRACE changes, tracing such wait_for loops in the mo