Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-08-02 Thread David Weinehall
On 2017-08-02 02:15, Pandiyan, Dhinakaran wrote: On Mon, 2017-07-31 at 15:41 -0700, Puthikorn Voravootivat wrote: But now you're suggesting another arbitrary narrow selection of panels based on limited evidence. I understand your point that the panel I observe is not the representative of the

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-08-01 Thread Pandiyan, Dhinakaran
On Mon, 2017-07-31 at 15:41 -0700, Puthikorn Voravootivat wrote: > > But now you're suggesting another arbitrary narrow selection of panels > > based on limited evidence. > > I understand your point that the panel I observe is not the > representative of the real world. > > My point is that we

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-07-31 Thread Puthikorn Voravootivat
> But now you're suggesting another arbitrary narrow selection of panels > based on limited evidence. I understand your point that the panel I observe is not the representative of the real world. My point is that we don't know that the panel will work or not unless we test all panel in the world.

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-07-31 Thread Jani Nikula
On Mon, 24 Jul 2017, Puthikorn Voravootivat wrote: > I saw a DP 1.3 panel that advertise AUX backlight brightness control > but not working properly. So it should work but not in real world. > I think that is good reason enough to add this as a heuristic. Are you suggesting the one panel you ment

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-07-25 Thread David Weinehall
On Tue, Jul 25, 2017 at 03:41:46PM +0300, David Weinehall wrote: > On 2017-07-25 02:15, Puthikorn Voravootivat wrote: > > I saw a DP 1.3 panel that advertise AUX backlight brightness control > > but not working properly. So it should work but not in real world. > > I think that is good reason enoug

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-07-25 Thread David Weinehall
On 2017-07-25 02:15, Puthikorn Voravootivat wrote: I saw a DP 1.3 panel that advertise AUX backlight brightness control but not working properly. So it should work but not in real world. I think that is good reason enough to add this as a heuristic. Either key it on eDP 1.4 and hope that it's

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-07-24 Thread Puthikorn Voravootivat
I saw a DP 1.3 panel that advertise AUX backlight brightness control but not working properly. So it should work but not in real world. I think that is good reason enough to add this as a heuristic. On Thu, Jul 20, 2017 at 1:27 PM, Pandiyan, Dhinakaran wrote: > > > > On Thu, 2017-07-20 at 10:06 +

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-07-20 Thread Pandiyan, Dhinakaran
On Thu, 2017-07-20 at 10:06 +, Tc, Jenny wrote: > > >> With older panels, AUX pin for backlight doesn't work. > > > > What evidence do you have to back up that claim? > > Debugging further it's found that the panel I am having doesn't support AUX > Backlight. > > cat /sys/kernel/debug/dr

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-07-20 Thread Pandiyan, Dhinakaran
On Thu, 2017-07-20 at 18:35 +0300, David Weinehall wrote: > On 2017-07-20 12:33, Jani Nikula wrote: > > On Wed, 19 Jul 2017, "Pandiyan, Dhinakaran" > > wrote: > >> On Wed, 2017-07-19 at 15:59 +0530, Jenny TC wrote: > >>> With older panels, AUX pin for backlight doesn't work. > > What evidence do

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-07-20 Thread David Weinehall
On 2017-07-20 12:33, Jani Nikula wrote: On Wed, 19 Jul 2017, "Pandiyan, Dhinakaran" wrote: On Wed, 2017-07-19 at 15:59 +0530, Jenny TC wrote: With older panels, AUX pin for backlight doesn't work. What evidence do you have to back up that claim? Chapter 10.1 does, at least according to my re

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-07-20 Thread Tc, Jenny
> >> With older panels, AUX pin for backlight doesn't work. > > What evidence do you have to back up that claim? Debugging further it's found that the panel I am having doesn't support AUX Backlight. cat /sys/kernel/debug/dri/0/eDP-1/i915_dpcd ... 0701: bb ff 00 00 With below change its

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-07-20 Thread Jani Nikula
On Wed, 19 Jul 2017, "Pandiyan, Dhinakaran" wrote: > On Wed, 2017-07-19 at 15:59 +0530, Jenny TC wrote: >> With older panels, AUX pin for backlight doesn't work. What evidence do you have to back up that claim? >> On some panels, this causes backlight issues on S3 resume. > > What is it that we

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-07-19 Thread Pandiyan, Dhinakaran
On Wed, 2017-07-19 at 15:59 +0530, Jenny TC wrote: > With older panels, AUX pin for backlight doesn't work. On some > panels, this causes backlight issues on S3 resume. What is it that we are missing in the resume path? > Enable the > feature only for eDP1.4 or later. I can't find the eDP 1.4

[Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-07-19 Thread Jenny TC
With older panels, AUX pin for backlight doesn't work. On some panels, this causes backlight issues on S3 resume. Enable the feature only for eDP1.4 or later. Fix-suggested-by: Puthikorn Voravootivat Signed-off-by: Jenny TC --- drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 6 +- 1 file ch