Re: [Intel-gfx] [PATCH] drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch

2015-07-10 Thread Dave Gordon
On 06/07/15 16:41, Chris Wilson wrote: On Mon, Jul 06, 2015 at 04:33:05PM +0200, Daniel Vetter wrote: On Mon, Jul 06, 2015 at 02:16:54PM +0100, Dave Gordon wrote: On 06/07/15 13:38, Daniel Vetter wrote: On Mon, Jul 06, 2015 at 12:52:51PM +0100, Dave Gordon wrote: On 03/07/15 16:42, Chris Wils

Re: [Intel-gfx] [PATCH] drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch

2015-07-06 Thread Chris Wilson
On Mon, Jul 06, 2015 at 04:33:05PM +0200, Daniel Vetter wrote: > On Mon, Jul 06, 2015 at 02:16:54PM +0100, Dave Gordon wrote: > > On 06/07/15 13:38, Daniel Vetter wrote: > > >On Mon, Jul 06, 2015 at 12:52:51PM +0100, Dave Gordon wrote: > > >>On 03/07/15 16:42, Chris Wilson wrote: > > >>>On Fri, Jul

Re: [Intel-gfx] [PATCH] drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch

2015-07-06 Thread Dave Gordon
On 06/07/15 15:33, Daniel Vetter wrote: On Mon, Jul 06, 2015 at 02:16:54PM +0100, Dave Gordon wrote: On 06/07/15 13:38, Daniel Vetter wrote: On Mon, Jul 06, 2015 at 12:52:51PM +0100, Dave Gordon wrote: On 03/07/15 16:42, Chris Wilson wrote: On Fri, Jul 03, 2015 at 02:27:31PM +0100, Arun Siluv

Re: [Intel-gfx] [PATCH] drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch

2015-07-06 Thread Daniel Vetter
On Mon, Jul 06, 2015 at 02:16:54PM +0100, Dave Gordon wrote: > On 06/07/15 13:38, Daniel Vetter wrote: > >On Mon, Jul 06, 2015 at 12:52:51PM +0100, Dave Gordon wrote: > >>On 03/07/15 16:42, Chris Wilson wrote: > >>>On Fri, Jul 03, 2015 at 02:27:31PM +0100, Arun Siluvery wrote: > In this WA we n

Re: [Intel-gfx] [PATCH] drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch

2015-07-06 Thread Dave Gordon
On 06/07/15 13:38, Daniel Vetter wrote: On Mon, Jul 06, 2015 at 12:52:51PM +0100, Dave Gordon wrote: On 03/07/15 16:42, Chris Wilson wrote: On Fri, Jul 03, 2015 at 02:27:31PM +0100, Arun Siluvery wrote: In this WA we need to set GEN8_L3SQCREG4[21:21] and reset it after PIPE_CONTROL instruction

Re: [Intel-gfx] [PATCH] drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch

2015-07-06 Thread Daniel Vetter
On Mon, Jul 06, 2015 at 12:52:51PM +0100, Dave Gordon wrote: > On 03/07/15 16:42, Chris Wilson wrote: > >On Fri, Jul 03, 2015 at 02:27:31PM +0100, Arun Siluvery wrote: > >>In this WA we need to set GEN8_L3SQCREG4[21:21] and reset it after > >>PIPE_CONTROL > >>instruction but there is a slight comp

Re: [Intel-gfx] [PATCH] drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch

2015-07-06 Thread Siluvery, Arun
On 06/07/2015 12:52, Dave Gordon wrote: On 03/07/15 16:42, Chris Wilson wrote: On Fri, Jul 03, 2015 at 02:27:31PM +0100, Arun Siluvery wrote: In this WA we need to set GEN8_L3SQCREG4[21:21] and reset it after PIPE_CONTROL instruction but there is a slight complication as this is applied in WA b

Re: [Intel-gfx] [PATCH] drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch

2015-07-06 Thread Dave Gordon
On 03/07/15 16:42, Chris Wilson wrote: On Fri, Jul 03, 2015 at 02:27:31PM +0100, Arun Siluvery wrote: In this WA we need to set GEN8_L3SQCREG4[21:21] and reset it after PIPE_CONTROL instruction but there is a slight complication as this is applied in WA batch where the values are only initialize

Re: [Intel-gfx] [PATCH] drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch

2015-07-04 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6719 -Summary- Platform Delta drm-intel-nightly Series Applied ILK

Re: [Intel-gfx] [PATCH] drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch

2015-07-03 Thread Chris Wilson
On Fri, Jul 03, 2015 at 02:27:31PM +0100, Arun Siluvery wrote: > In this WA we need to set GEN8_L3SQCREG4[21:21] and reset it after > PIPE_CONTROL > instruction but there is a slight complication as this is applied in WA batch > where the values are only initialized once. > Dave identified an issu

[Intel-gfx] [PATCH] drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch

2015-07-03 Thread Arun Siluvery
In this WA we need to set GEN8_L3SQCREG4[21:21] and reset it after PIPE_CONTROL instruction but there is a slight complication as this is applied in WA batch where the values are only initialized once. Dave identified an issue with the current implementation where the register value is read once a