Re: [Intel-gfx] [PATCH] drm/i915: Turn off hsync and vsync on ADPA when disabling crt

2013-03-06 Thread Daniel Vetter
On Tue, Mar 05, 2013 at 02:24:48PM +0100, Patrik Jakobsson wrote: > According to PRM we need to disable hsync and vsync even though ADPA is > disabled. The previous code did infact do the opposite so we fix it. > > Signed-off-by: Patrik Jakobsson Bugreporter confirmed that it works, so merged to

Re: [Intel-gfx] [PATCH] drm/i915: Turn off hsync and vsync on ADPA when disabling crt

2013-03-05 Thread Daniel Vetter
On Tue, Mar 05, 2013 at 05:41:04PM +0200, Ville Syrjälä wrote: > On Tue, Mar 05, 2013 at 04:23:59PM +0100, Daniel Vetter wrote: > > On Tue, Mar 05, 2013 at 04:59:12PM +0200, Ville Syrjälä wrote: > > > On Tue, Mar 05, 2013 at 03:33:26PM +0100, Patrik Jakobsson wrote: > > > > > Accroding to the docs

Re: [Intel-gfx] [PATCH] drm/i915: Turn off hsync and vsync on ADPA when disabling crt

2013-03-05 Thread Ville Syrjälä
On Tue, Mar 05, 2013 at 04:23:59PM +0100, Daniel Vetter wrote: > On Tue, Mar 05, 2013 at 04:59:12PM +0200, Ville Syrjälä wrote: > > On Tue, Mar 05, 2013 at 03:33:26PM +0100, Patrik Jakobsson wrote: > > > > Accroding to the docs these bits don't exist on PCH platforms. > > > > intel_crt_dpms() alrea

Re: [Intel-gfx] [PATCH] drm/i915: Turn off hsync and vsync on ADPA when disabling crt

2013-03-05 Thread Daniel Vetter
On Tue, Mar 05, 2013 at 04:59:12PM +0200, Ville Syrjälä wrote: > On Tue, Mar 05, 2013 at 03:33:26PM +0100, Patrik Jakobsson wrote: > > > Accroding to the docs these bits don't exist on PCH platforms. > > > intel_crt_dpms() already has a check for this, so I suppose > > > intel_disable_crt() should

Re: [Intel-gfx] [PATCH] drm/i915: Turn off hsync and vsync on ADPA when disabling crt

2013-03-05 Thread Patrik Jakobsson
On Tue, Mar 5, 2013 at 3:59 PM, Ville Syrjälä wrote: > On Tue, Mar 05, 2013 at 03:33:26PM +0100, Patrik Jakobsson wrote: >> > Accroding to the docs these bits don't exist on PCH platforms. >> > intel_crt_dpms() already has a check for this, so I suppose >> > intel_disable_crt() should have one too

Re: [Intel-gfx] [PATCH] drm/i915: Turn off hsync and vsync on ADPA when disabling crt

2013-03-05 Thread Ville Syrjälä
On Tue, Mar 05, 2013 at 03:33:26PM +0100, Patrik Jakobsson wrote: > > Accroding to the docs these bits don't exist on PCH platforms. > > intel_crt_dpms() already has a check for this, so I suppose > > intel_disable_crt() should have one too. > > > > Also I noticed that we seem to have the hsync and

Re: [Intel-gfx] [PATCH] drm/i915: Turn off hsync and vsync on ADPA when disabling crt

2013-03-05 Thread Patrik Jakobsson
> Accroding to the docs these bits don't exist on PCH platforms. > intel_crt_dpms() already has a check for this, so I suppose > intel_disable_crt() should have one too. > > Also I noticed that we seem to have the hsync and vsync disable > bits reversed. At least that's what the docs are telling me

Re: [Intel-gfx] [PATCH] drm/i915: Turn off hsync and vsync on ADPA when disabling crt

2013-03-05 Thread Ville Syrjälä
On Tue, Mar 05, 2013 at 02:24:48PM +0100, Patrik Jakobsson wrote: > According to PRM we need to disable hsync and vsync even though ADPA is > disabled. The previous code did infact do the opposite so we fix it. > > Signed-off-by: Patrik Jakobsson > > --- > drivers/gpu/drm/i915/intel_crt.c |2

[Intel-gfx] [PATCH] drm/i915: Turn off hsync and vsync on ADPA when disabling crt

2013-03-05 Thread Patrik Jakobsson
According to PRM we need to disable hsync and vsync even though ADPA is disabled. The previous code did infact do the opposite so we fix it. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/i915/intel_crt.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm