Re: [Intel-gfx] [PATCH] drm/i915: Suppress warning for MTRR failure if PAT is enabled

2012-02-20 Thread Chris Wilson
On Mon, 20 Feb 2012 19:20:03 +, Chris Wilson wrote: > Emitting a spurious warning about poor graphics performance when MTRR > are irrelevant leads to confused users and useless bug reports. Darn, a bigger nail in the coffin of this patch is the lack of EXPORT_SYMBOL for pat_enabled. -Chris

Re: [Intel-gfx] [PATCH] drm/i915: Suppress warning for MTRR failure if PAT is enabled

2012-02-20 Thread Chris Wilson
On Mon, 20 Feb 2012 12:21:43 -0800, Eric Anholt wrote: > Now that PAT has been reliable without MTRRs in place for a while, I > agree with the patch (but not with removing the braces around the > multi-line printf). I thought the braces around the single line was a checkpatch violation. Having ru

Re: [Intel-gfx] [PATCH] drm/i915: Suppress warning for MTRR failure if PAT is enabled

2012-02-20 Thread Eric Anholt
On Mon, 20 Feb 2012 19:20:03 +, Chris Wilson wrote: > Emitting a spurious warning about poor graphics performance when MTRR > are irrelevant leads to confused users and useless bug reports. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=41648 > Signed-off-by: Chris Wilson Now

[Intel-gfx] [PATCH] drm/i915: Suppress warning for MTRR failure if PAT is enabled

2012-02-20 Thread Chris Wilson
Emitting a spurious warning about poor graphics performance when MTRR are irrelevant leads to confused users and useless bug reports. References: https://bugs.freedesktop.org/show_bug.cgi?id=41648 Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_dma.c |4 ++-- 1 files changed, 2 ins