Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-05-10 Thread Chris Wilson
On Thu, 19 Apr 2012 13:55:04 -0400, Adam Jackson wrote: > On Thu, 2012-04-19 at 18:10 +0200, Takashi Iwai wrote: > > > This patch adds a flag to disable the hotplug during PM operation for > > avoiding such a race. > > > > Cc: > > Signed-off-by: Takashi Iwai > > This seems simpler (untested):

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-05-10 Thread Chris Wilson
On Thu, 10 May 2012 11:39:49 +0200, Takashi Iwai wrote: > At Thu, 10 May 2012 10:25:44 +0100, > Chris Wilson wrote: > > > > On Thu, 10 May 2012 11:19:11 +0200, Takashi Iwai wrote: > > > At Thu, 10 May 2012 11:06:46 +0200, > > > Daniel Vetter wrote: > > > > This patch is not just for hotplug, but

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-05-10 Thread Daniel Vetter
On Thu, May 10, 2012 at 11:39:49AM +0200, Takashi Iwai wrote: > At Thu, 10 May 2012 10:25:44 +0100, > Chris Wilson wrote: > > > > On Thu, 10 May 2012 11:19:11 +0200, Takashi Iwai wrote: > > > At Thu, 10 May 2012 11:06:46 +0200, > > > Daniel Vetter wrote: > > > > This patch is not just for hotplug

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-05-10 Thread Takashi Iwai
At Thu, 10 May 2012 10:25:44 +0100, Chris Wilson wrote: > > On Thu, 10 May 2012 11:19:11 +0200, Takashi Iwai wrote: > > At Thu, 10 May 2012 11:06:46 +0200, > > Daniel Vetter wrote: > > > This patch is not just for hotplug, but for all the delayed work and timer > > > stuff the driver does. And we

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-05-10 Thread Chris Wilson
On Thu, 10 May 2012 11:19:11 +0200, Takashi Iwai wrote: > At Thu, 10 May 2012 11:06:46 +0200, > Daniel Vetter wrote: > > This patch is not just for hotplug, but for all the delayed work and timer > > stuff the driver does. And we _do_ have a bug report that leaking the rps > > work (for snb+ turbo

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-05-10 Thread Takashi Iwai
At Thu, 10 May 2012 11:06:46 +0200, Daniel Vetter wrote: > > On Thu, May 10, 2012 at 10:40:52AM +0200, Takashi Iwai wrote: > > At Thu, 10 May 2012 10:29:19 +0200, > > Daniel Vetter wrote: > > > > > > On Thu, May 10, 2012 at 08:34:43AM +0200, Takashi Iwai wrote: > > > > At Wed, 25 Apr 2012 10:14:5

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-05-10 Thread Daniel Vetter
On Thu, May 10, 2012 at 10:40:52AM +0200, Takashi Iwai wrote: > At Thu, 10 May 2012 10:29:19 +0200, > Daniel Vetter wrote: > > > > On Thu, May 10, 2012 at 08:34:43AM +0200, Takashi Iwai wrote: > > > At Wed, 25 Apr 2012 10:14:51 +0200, > > > Takashi Iwai wrote: > > > > > > > > At Thu, 19 Apr 2012

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-05-10 Thread Takashi Iwai
At Thu, 10 May 2012 10:29:19 +0200, Daniel Vetter wrote: > > On Thu, May 10, 2012 at 08:34:43AM +0200, Takashi Iwai wrote: > > At Wed, 25 Apr 2012 10:14:51 +0200, > > Takashi Iwai wrote: > > > > > > At Thu, 19 Apr 2012 20:11:53 +0200, > > > Takashi Iwai wrote: > > > > > > > > At Thu, 19 Apr 2012

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-05-10 Thread Daniel Vetter
On Thu, May 10, 2012 at 08:34:43AM +0200, Takashi Iwai wrote: > At Wed, 25 Apr 2012 10:14:51 +0200, > Takashi Iwai wrote: > > > > At Thu, 19 Apr 2012 20:11:53 +0200, > > Takashi Iwai wrote: > > > > > > At Thu, 19 Apr 2012 13:55:04 -0400, > > > Adam Jackson wrote: > > > > > > > > On Thu, 2012-04-

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-05-09 Thread Takashi Iwai
At Wed, 25 Apr 2012 10:14:51 +0200, Takashi Iwai wrote: > > At Thu, 19 Apr 2012 20:11:53 +0200, > Takashi Iwai wrote: > > > > At Thu, 19 Apr 2012 13:55:04 -0400, > > Adam Jackson wrote: > > > > > > On Thu, 2012-04-19 at 18:10 +0200, Takashi Iwai wrote: > > > > > > > This patch adds a flag to di

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-25 Thread Takashi Iwai
At Thu, 19 Apr 2012 20:11:53 +0200, Takashi Iwai wrote: > > At Thu, 19 Apr 2012 13:55:04 -0400, > Adam Jackson wrote: > > > > On Thu, 2012-04-19 at 18:10 +0200, Takashi Iwai wrote: > > > > > This patch adds a flag to disable the hotplug during PM operation for > > > avoiding such a race. > > >

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Takashi Iwai
At Thu, 19 Apr 2012 13:55:04 -0400, Adam Jackson wrote: > > On Thu, 2012-04-19 at 18:10 +0200, Takashi Iwai wrote: > > > This patch adds a flag to disable the hotplug during PM operation for > > avoiding such a race. > > > > Cc: > > Signed-off-by: Takashi Iwai > > This seems simpler (untested

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Adam Jackson
On Thu, 2012-04-19 at 18:10 +0200, Takashi Iwai wrote: > This patch adds a flag to disable the hotplug during PM operation for > avoiding such a race. > > Cc: > Signed-off-by: Takashi Iwai This seems simpler (untested): diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Daniel Vetter
On Thu, Apr 19, 2012 at 06:38:13PM +0200, Takashi Iwai wrote: > At Thu, 19 Apr 2012 18:29:47 +0200, > Daniel Vetter wrote: > > > > On Thu, Apr 19, 2012 at 06:10:18PM +0200, Takashi Iwai wrote: > > > The hotplug work can be still kicked off via irq during PM, and this > > > may conflict with the re

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Takashi Iwai
At Thu, 19 Apr 2012 18:29:47 +0200, Daniel Vetter wrote: > > On Thu, Apr 19, 2012 at 06:10:18PM +0200, Takashi Iwai wrote: > > The hotplug work can be still kicked off via irq during PM, and this > > may conflict with the resume procedure. For example, eDP on SNB > > machine shows WARNING like be

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Takashi Iwai
At Thu, 19 Apr 2012 17:22:47 +0100, Chris Wilson wrote: > > On Thu, 19 Apr 2012 18:10:18 +0200, Takashi Iwai wrote: > > The hotplug work can be still kicked off via irq during PM, and this > > may conflict with the resume procedure. For example, eDP on SNB > > machine shows WARNING like below du

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Daniel Vetter
On Thu, Apr 19, 2012 at 06:10:18PM +0200, Takashi Iwai wrote: > The hotplug work can be still kicked off via irq during PM, and this > may conflict with the resume procedure. For example, eDP on SNB > machine shows WARNING like below during the resume: > > WARNING: at > /usr/src/packages/BUILD

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Chris Wilson
On Thu, 19 Apr 2012 18:10:18 +0200, Takashi Iwai wrote: > The hotplug work can be still kicked off via irq during PM, and this > may conflict with the resume procedure. For example, eDP on SNB > machine shows WARNING like below during the resume: Daniel and I were just discussing the number of w

[Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Takashi Iwai
The hotplug work can be still kicked off via irq during PM, and this may conflict with the resume procedure. For example, eDP on SNB machine shows WARNING like below during the resume: WARNING: at /usr/src/packages/BUILD/kernel-default-3.0.13/linux-3.0/drivers/gpu/drm/i915/intel_dp.c:332 inte