Re: [Intel-gfx] [PATCH] drm/i915: Stop gathering error states for CS error interrupts

2014-11-24 Thread Chris Wilson
On Mon, Nov 24, 2014 at 09:57:32PM +0100, Daniel Vetter wrote: > I looked at this and it gets ugly fast. Given that we seem to have a quite > substantial false-positive (found one more by just reading recent bug > spam) rate and haven't enabled this on gen5+ I've decided to just merge > this one he

Re: [Intel-gfx] [PATCH] drm/i915: Stop gathering error states for CS error interrupts

2014-11-24 Thread Daniel Vetter
On Wed, Nov 05, 2014 at 10:56:06AM +0100, Daniel Vetter wrote: > On Wed, Nov 05, 2014 at 08:35:01AM +, Chris Wilson wrote: > > On Tue, Nov 04, 2014 at 03:52:22PM +0100, Daniel Vetter wrote: > > > There's quite a few bug reports with error states where the error > > > reasons makes just about no

Re: [Intel-gfx] [PATCH] drm/i915: Stop gathering error states for CS error interrupts

2014-11-05 Thread Daniel Vetter
On Wed, Nov 05, 2014 at 08:35:01AM +, Chris Wilson wrote: > On Tue, Nov 04, 2014 at 03:52:22PM +0100, Daniel Vetter wrote: > > There's quite a few bug reports with error states where the error > > reasons makes just about no sense at all. Like dying on tlbs for a > > display plane that's not ev

Re: [Intel-gfx] [PATCH] drm/i915: Stop gathering error states for CS error interrupts

2014-11-05 Thread Chris Wilson
On Tue, Nov 04, 2014 at 03:52:22PM +0100, Daniel Vetter wrote: > There's quite a few bug reports with error states where the error > reasons makes just about no sense at all. Like dying on tlbs for a > display plane that's not even there. Also users don't really report a > lot of bad side effects g

Re: [Intel-gfx] [PATCH] drm/i915: Stop gathering error states for CS error interrupts

2014-11-04 Thread Jani Nikula
On Tue, 04 Nov 2014, Daniel Vetter wrote: > There's quite a few bug reports with error states where the error > reasons makes just about no sense at all. Like dying on tlbs for a > display plane that's not even there. Also users don't really report a > lot of bad side effects generally, just the e

[Intel-gfx] [PATCH] drm/i915: Stop gathering error states for CS error interrupts

2014-11-04 Thread Daniel Vetter
There's quite a few bug reports with error states where the error reasons makes just about no sense at all. Like dying on tlbs for a display plane that's not even there. Also users don't really report a lot of bad side effects generally, just the error states. Furthermore we don't even enable thes