Re: [Intel-gfx] [PATCH] drm/i915: Rewrite vlv_find_best_dpll()

2013-09-24 Thread Ville Syrjälä
On Tue, Sep 24, 2013 at 11:23:31AM +0200, Daniel Vetter wrote: > On Mon, Sep 23, 2013 at 09:03:10PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > vlv_find_best_dpll() has several integer over/underflow issues, > > includes a hand rolled DIV_ROUND_CLOSEST(), has a boa

Re: [Intel-gfx] [PATCH] drm/i915: Rewrite vlv_find_best_dpll()

2013-09-24 Thread Daniel Vetter
On Mon, Sep 23, 2013 at 09:03:10PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > vlv_find_best_dpll() has several integer over/underflow issues, > includes a hand rolled DIV_ROUND_CLOSEST(), has a boat load of > variables, some slightly weird math, and it doesn't look very

[Intel-gfx] [PATCH] drm/i915: Rewrite vlv_find_best_dpll()

2013-09-23 Thread ville . syrjala
From: Ville Syrjälä vlv_find_best_dpll() has several integer over/underflow issues, includes a hand rolled DIV_ROUND_CLOSEST(), has a boat load of variables, some slightly weird math, and it doesn't look very nice either. Rather than try to deal with each issue separately I just decided to rewri