Re: [Intel-gfx] [PATCH] drm/i915: Rework FBC schedule locking

2018-03-21 Thread Paulo Zanoni
Em Sex, 2018-03-16 às 16:01 +0100, Maarten Lankhorst escreveu: > Instead of taking fbc->lock inside the worker, don't take any lock > and cancel the work synchronously to prevent races. Since the worker > waits for a vblank before activating, wake up all vblank waiters > after > signalling the canc

Re: [Intel-gfx] [PATCH] drm/i915: Rework FBC schedule locking

2018-03-21 Thread Rodrigo Vivi
On Fri, Mar 16, 2018 at 04:01:21PM +0100, Maarten Lankhorst wrote: > Instead of taking fbc->lock inside the worker, don't take any lock > and cancel the work synchronously to prevent races. Since the worker > waits for a vblank before activating, wake up all vblank waiters after > signalling the ca

[Intel-gfx] [PATCH] drm/i915: Rework FBC schedule locking

2018-03-16 Thread Maarten Lankhorst
Instead of taking fbc->lock inside the worker, don't take any lock and cancel the work synchronously to prevent races. Since the worker waits for a vblank before activating, wake up all vblank waiters after signalling the cancel through unsetting work->scheduled_vblank. This will make sure that we