Re: [Intel-gfx] [PATCH] drm/i915: Replace has_bsd/blt/vebox with a mask

2013-10-16 Thread Daniel Vetter
On Tue, Oct 15, 2013 at 10:02:57AM -0700, Ben Widawsky wrote: > From: Ben Widawsky > > I've sent this patch several times for various reasons. It essentially > cleans up a lot of code where we need to do something per ring, and want > to query whether or not the ring exists on that hardware. > >

[Intel-gfx] [PATCH] drm/i915: Replace has_bsd/blt/vebox with a mask

2013-10-15 Thread Ben Widawsky
From: Ben Widawsky I've sent this patch several times for various reasons. It essentially cleans up a lot of code where we need to do something per ring, and want to query whether or not the ring exists on that hardware. It has various uses coming up, but for now it shouldn't be too offensive.

Re: [Intel-gfx] [PATCH] drm/i915: Replace has_bsd/blt/vebox with a mask

2013-10-15 Thread Chris Wilson
On Tue, Oct 15, 2013 at 08:03:25AM -0700, Ben Widawsky wrote: > On Tue, Oct 15, 2013 at 09:50:39AM +0100, Chris Wilson wrote: > > On Mon, Oct 14, 2013 at 08:46:22PM -0700, Ben Widawsky wrote: > > > -cleanup_vebox_ring: > > > - intel_cleanup_ring_buffer(&dev_priv->ring[VECS]); > > > -cleanup_blt_rin

Re: [Intel-gfx] [PATCH] drm/i915: Replace has_bsd/blt/vebox with a mask

2013-10-15 Thread Ben Widawsky
On Tue, Oct 15, 2013 at 09:50:39AM +0100, Chris Wilson wrote: > On Mon, Oct 14, 2013 at 08:46:22PM -0700, Ben Widawsky wrote: > > -cleanup_vebox_ring: > > - intel_cleanup_ring_buffer(&dev_priv->ring[VECS]); > > -cleanup_blt_ring: > > - intel_cleanup_ring_buffer(&dev_priv->ring[BCS]); > > -clean

Re: [Intel-gfx] [PATCH] drm/i915: Replace has_bsd/blt/vebox with a mask

2013-10-15 Thread Chris Wilson
On Mon, Oct 14, 2013 at 08:46:22PM -0700, Ben Widawsky wrote: > -cleanup_vebox_ring: > - intel_cleanup_ring_buffer(&dev_priv->ring[VECS]); > -cleanup_blt_ring: > - intel_cleanup_ring_buffer(&dev_priv->ring[BCS]); > -cleanup_bsd_ring: > - intel_cleanup_ring_buffer(&dev_priv->ring[VCS]);

[Intel-gfx] [PATCH] drm/i915: Replace has_bsd/blt/vebox with a mask

2013-10-14 Thread Ben Widawsky
From: Ben Widawsky I've sent this patch several times for various reasons. It essentially cleans up a lot of code where we need to do something per ring, and want to query whether or not the ring exists on that hardware. It has various uses coming up, but for now it shouldn't be too offensive.