Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-29 Thread Bloomfield, Jon
> -Original Message- > From: Joonas Lahtinen > Sent: Monday, July 29, 2019 5:50 AM > To: Bloomfield, Jon ; intel- > g...@lists.freedesktop.org; Chris Wilson > Cc: Ursulin, Tvrtko > Subject: RE: [PATCH] drm/i915: Replace hangcheck by heartbeats > > Quoting Chris Wilson (2019-07-29 12:45:

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-29 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-07-29 12:45:52) > Quoting Joonas Lahtinen (2019-07-29 10:26:47) > > Ok, so just confirming here. The plan is still to have userspace set a > > per context (or per request) time limit for expected completion of a > > request. This will be useful for the media workloads tha

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-29 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-07-27 01:27:02) > Quoting Bloomfield, Jon (2019-07-26 23:19:38) > > Hmmn. We're still on orthogonal perspectives as far as our previous > > arguments stand. But it doesn't matter because while thinking through your > > replies, I realized there is one argument in favour

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-29 Thread Chris Wilson
Quoting Joonas Lahtinen (2019-07-29 10:26:47) > Quoting Chris Wilson (2019-07-27 01:27:02) > > Quoting Bloomfield, Jon (2019-07-26 23:19:38) > > > Hmmn. We're still on orthogonal perspectives as far as our previous > > > arguments stand. But it doesn't matter because while thinking through > > >

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-26 Thread Chris Wilson
Quoting Bloomfield, Jon (2019-07-26 23:19:38) > Hmmn. We're still on orthogonal perspectives as far as our previous arguments > stand. But it doesn't matter because while thinking through your replies, I > realized there is one argument in favour, which trumps all my previous > arguments against

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-26 Thread Bloomfield, Jon
Hmmn. We're still on orthogonal perspectives as far as our previous arguments stand. But it doesn't matter because while thinking through your replies, I realized there is one argument in favour, which trumps all my previous arguments against this patch - it makes things deterministic. Without t

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-26 Thread Chris Wilson
Quoting Bloomfield, Jon (2019-07-26 21:58:38) > > From: Chris Wilson > > It's no more often than before, you have to fail to advance within an > > interval, and then deny preemption request. > > It's entrapment. You are creating an artificial workload for the context to > impede. Before that art

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-26 Thread Bloomfield, Jon
> -Original Message- > From: Chris Wilson > Sent: Friday, July 26, 2019 1:11 PM > To: Bloomfield, Jon ; intel- > g...@lists.freedesktop.org > Cc: Joonas Lahtinen ; Ursulin, Tvrtko > > Subject: RE: [PATCH] drm/i915: Replace hangcheck by heartbeats > > Quoting Bloomfield, Jon (2019-07-26 1

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-26 Thread Chris Wilson
Quoting Bloomfield, Jon (2019-07-26 16:00:06) > > -Original Message- > > From: Chris Wilson > > Sent: Thursday, July 25, 2019 4:52 PM > > To: Bloomfield, Jon ; intel- > > g...@lists.freedesktop.org > > Cc: Joonas Lahtinen ; Ursulin, Tvrtko > > > > Subject: RE: [PATCH] drm/i915: Replace ha

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-26 Thread Bloomfield, Jon
> -Original Message- > From: Chris Wilson > Sent: Thursday, July 25, 2019 4:52 PM > To: Bloomfield, Jon ; intel- > g...@lists.freedesktop.org > Cc: Joonas Lahtinen ; Ursulin, Tvrtko > > Subject: RE: [PATCH] drm/i915: Replace hangcheck by heartbeats > > Quoting Bloomfield, Jon (2019-07-26

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-25 Thread Chris Wilson
Quoting Bloomfield, Jon (2019-07-26 00:41:49) > > -Original Message- > > From: Chris Wilson > > Sent: Thursday, July 25, 2019 4:28 PM > > To: Bloomfield, Jon ; intel- > > g...@lists.freedesktop.org > > Cc: Joonas Lahtinen ; Ursulin, Tvrtko > > > > Subject: RE: [PATCH] drm/i915: Replace ha

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-25 Thread Bloomfield, Jon
> -Original Message- > From: Chris Wilson > Sent: Thursday, July 25, 2019 4:28 PM > To: Bloomfield, Jon ; intel- > g...@lists.freedesktop.org > Cc: Joonas Lahtinen ; Ursulin, Tvrtko > > Subject: RE: [PATCH] drm/i915: Replace hangcheck by heartbeats > > Quoting Bloomfield, Jon (2019-07-26

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-25 Thread Chris Wilson
Quoting Bloomfield, Jon (2019-07-26 00:21:47) > > -Original Message- > > From: Chris Wilson > > Sent: Thursday, July 25, 2019 4:17 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Chris Wilson ; Joonas Lahtinen > > ; Ursulin, Tvrtko > > ; > > Bloomfield, Jon > > Subject: [PATCH] drm/i9

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-25 Thread Bloomfield, Jon
> -Original Message- > From: Chris Wilson > Sent: Thursday, July 25, 2019 4:17 PM > To: intel-gfx@lists.freedesktop.org > Cc: Chris Wilson ; Joonas Lahtinen > ; Ursulin, Tvrtko ; > Bloomfield, Jon > Subject: [PATCH] drm/i915: Replace hangcheck by heartbeats > > Replace sampling the engin

[Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-25 Thread Chris Wilson
Replace sampling the engine state every so often with a periodic heartbeat request to measure the health of an engine. This is coupled with the forced-preemption to allow long running requests to survive so long as they do not block other users. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc