Re: [Intel-gfx] [PATCH] drm/i915: Rename global i915 to i915_modparams

2017-09-19 Thread Jani Nikula
On Tue, 19 Sep 2017, Joonas Lahtinen wrote: > On Tue, 2017-09-19 at 16:15 +0300, Ville Syrjälä wrote: >> On Tue, Sep 19, 2017 at 04:07:17PM +0300, Joonas Lahtinen wrote: >> > On Tue, 2017-09-19 at 13:22 +0300, Ville Syrjälä wrote: >> > > On Tue, Sep 19, 2017 at 11:24:41AM +0300, Joonas Lahtinen wr

Re: [Intel-gfx] [PATCH] drm/i915: Rename global i915 to i915_modparams

2017-09-19 Thread Joonas Lahtinen
On Tue, 2017-09-19 at 16:15 +0300, Ville Syrjälä wrote: > On Tue, Sep 19, 2017 at 04:07:17PM +0300, Joonas Lahtinen wrote: > > On Tue, 2017-09-19 at 13:22 +0300, Ville Syrjälä wrote: > > > On Tue, Sep 19, 2017 at 11:24:41AM +0300, Joonas Lahtinen wrote: > > > > On Mon, 2017-09-18 at 22:07 +0200, Mi

Re: [Intel-gfx] [PATCH] drm/i915: Rename global i915 to i915_modparams

2017-09-19 Thread Ville Syrjälä
On Tue, Sep 19, 2017 at 04:07:17PM +0300, Joonas Lahtinen wrote: > On Tue, 2017-09-19 at 13:22 +0300, Ville Syrjälä wrote: > > On Tue, Sep 19, 2017 at 11:24:41AM +0300, Joonas Lahtinen wrote: > > > On Mon, 2017-09-18 at 22:07 +0200, Michal Wajdeczko wrote: > > > > On Mon, 18 Sep 2017 21:11:40 +0200

Re: [Intel-gfx] [PATCH] drm/i915: Rename global i915 to i915_modparams

2017-09-19 Thread Joonas Lahtinen
On Tue, 2017-09-19 at 13:22 +0300, Ville Syrjälä wrote: > On Tue, Sep 19, 2017 at 11:24:41AM +0300, Joonas Lahtinen wrote: > > On Mon, 2017-09-18 at 22:07 +0200, Michal Wajdeczko wrote: > > > On Mon, 18 Sep 2017 21:11:40 +0200, Jani Nikula > > > wrote: > > > > > > > On Mon, 18 Sep 2017, Michal

Re: [Intel-gfx] [PATCH] drm/i915: Rename global i915 to i915_modparams

2017-09-19 Thread Ville Syrjälä
On Tue, Sep 19, 2017 at 11:24:41AM +0300, Joonas Lahtinen wrote: > On Mon, 2017-09-18 at 22:07 +0200, Michal Wajdeczko wrote: > > On Mon, 18 Sep 2017 21:11:40 +0200, Jani Nikula > > wrote: > > > > > On Mon, 18 Sep 2017, Michal Wajdeczko wrote: > > > > Our global struct with params is named exa

Re: [Intel-gfx] [PATCH] drm/i915: Rename global i915 to i915_modparams

2017-09-19 Thread Joonas Lahtinen
On Mon, 2017-09-18 at 22:07 +0200, Michal Wajdeczko wrote: > On Mon, 18 Sep 2017 21:11:40 +0200, Jani Nikula > wrote: > > > On Mon, 18 Sep 2017, Michal Wajdeczko wrote: > > > Our global struct with params is named exactly the same way > > > as new preferred name for the drm_i915_private functi

Re: [Intel-gfx] [PATCH] drm/i915: Rename global i915 to i915_modparams

2017-09-19 Thread Jani Nikula
On Mon, 18 Sep 2017, Michal Wajdeczko wrote: > On Mon, 18 Sep 2017 21:11:40 +0200, Jani Nikula > wrote: > >> On Mon, 18 Sep 2017, Michal Wajdeczko wrote: >>> Our global struct with params is named exactly the same way >>> as new preferred name for the drm_i915_private function parameter. >>> T

Re: [Intel-gfx] [PATCH] drm/i915: Rename global i915 to i915_modparams

2017-09-18 Thread Michal Wajdeczko
On Mon, 18 Sep 2017 21:12:25 +0200, Chris Wilson wrote: Quoting Michal Wajdeczko (2017-09-18 19:55:07) Our global struct with params is named exactly the same way as new preferred name for the drm_i915_private function parameter. To avoid such name reuse lets use different name for the globa

Re: [Intel-gfx] [PATCH] drm/i915: Rename global i915 to i915_modparams

2017-09-18 Thread Michal Wajdeczko
On Mon, 18 Sep 2017 21:11:40 +0200, Jani Nikula wrote: On Mon, 18 Sep 2017, Michal Wajdeczko wrote: Our global struct with params is named exactly the same way as new preferred name for the drm_i915_private function parameter. To avoid such name reuse lets use different name for the global.

Re: [Intel-gfx] [PATCH] drm/i915: Rename global i915 to i915_modparams

2017-09-18 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-09-18 19:55:07) > Our global struct with params is named exactly the same way > as new preferred name for the drm_i915_private function parameter. > To avoid such name reuse lets use different name for the global. > > v4: introduction of mkwrite() > > Credits-to: Co

Re: [Intel-gfx] [PATCH] drm/i915: Rename global i915 to i915_modparams

2017-09-18 Thread Jani Nikula
On Mon, 18 Sep 2017, Michal Wajdeczko wrote: > Our global struct with params is named exactly the same way > as new preferred name for the drm_i915_private function parameter. > To avoid such name reuse lets use different name for the global. > > v4: introduction of mkwrite() Why? I don't know w

[Intel-gfx] [PATCH] drm/i915: Rename global i915 to i915_modparams

2017-09-18 Thread Michal Wajdeczko
Our global struct with params is named exactly the same way as new preferred name for the drm_i915_private function parameter. To avoid such name reuse lets use different name for the global. v4: introduction of mkwrite() Credits-to: Coccinelle @@ identifier n; expression e; @@ ( - i915.n