Re: [Intel-gfx] [PATCH] drm/i915: Remove obsolete engine clenaup

2019-07-17 Thread Tvrtko Ursulin
On 17/07/2019 14:24, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:18:56) On 17/07/2019 08:46, Chris Wilson wrote: Remove the outer layer cleanup of engine stubs; it no longer tries to Who is "it"? i915_drv.c preallocate and so is not responsible for either the allocation or

Re: [Intel-gfx] [PATCH] drm/i915: Remove obsolete engine clenaup

2019-07-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-17 14:18:56) > > On 17/07/2019 08:46, Chris Wilson wrote: > > Remove the outer layer cleanup of engine stubs; it no longer tries to > > Who is "it"? i915_drv.c > > preallocate and so is not responsible for either the allocation or free. > > By the time we call th

Re: [Intel-gfx] [PATCH] drm/i915: Remove obsolete engine clenaup

2019-07-17 Thread Tvrtko Ursulin
On 17/07/2019 08:46, Chris Wilson wrote: > Remove the outer layer cleanup of engine stubs; it no longer tries to Who is "it"? > preallocate and so is not responsible for either the allocation or free. > By the time we call the cleanup function, we already have cleaned up the > engines. I see:

[Intel-gfx] [PATCH] drm/i915: Remove obsolete engine clenaup

2019-07-17 Thread Chris Wilson
Remove the outer layer cleanup of engine stubs; it no longer tries to preallocate and so is not responsible for either the allocation or free. By the time we call the cleanup function, we already have cleaned up the engines. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.c | 14 +-