Re: [Intel-gfx] [PATCH] drm/i915: Remove obsolete code from intelfb_alloc()

2015-12-21 Thread Daniel Vetter
On Sat, Dec 19, 2015 at 03:02:49PM +, Chris Wilson wrote: > On Sat, Dec 19, 2015 at 03:40:39PM +0100, Lukas Wunner wrote: > > Clean up after 0c82312f3f15 ("drm/i915: Pin the ifbdev for the > > info->system_base GGTT mmapping"): > > > > At each of the remaining "goto out" in intelfb_alloc(), fb

Re: [Intel-gfx] [PATCH] drm/i915: Remove obsolete code from intelfb_alloc()

2015-12-19 Thread Chris Wilson
On Sat, Dec 19, 2015 at 03:40:39PM +0100, Lukas Wunner wrote: > Clean up after 0c82312f3f15 ("drm/i915: Pin the ifbdev for the > info->system_base GGTT mmapping"): > > At each of the remaining "goto out" in intelfb_alloc(), fb can only be > either an ERR_PTR or NULL, so the call to drm_framebuffer

[Intel-gfx] [PATCH] drm/i915: Remove obsolete code from intelfb_alloc()

2015-12-19 Thread Lukas Wunner
Clean up after 0c82312f3f15 ("drm/i915: Pin the ifbdev for the info->system_base GGTT mmapping"): At each of the remaining "goto out" in intelfb_alloc(), fb can only be either an ERR_PTR or NULL, so the call to drm_framebuffer_unreference() is now obsolete. Cc: Daniel Vetter Cc: Chris Wilson Si