Re: [Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

2015-11-24 Thread Daniel Stone
Hey, On 24 November 2015 at 13:59, Daniel Vetter wrote: > On Tue, Nov 24, 2015 at 01:29:07PM +, Daniel Stone wrote: >> On 24 November 2015 at 13:27, Chris Wilson wrote: >> > On Tue, Nov 24, 2015 at 01:17:57PM +, Tvrtko Ursulin wrote: >> >> On 24/11/15 12:53, Chris Wilson wrote: >> >> >Th

Re: [Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

2015-11-24 Thread Daniel Vetter
On Tue, Nov 24, 2015 at 01:29:07PM +, Daniel Stone wrote: > Hi, > > On 24 November 2015 at 13:27, Chris Wilson wrote: > > On Tue, Nov 24, 2015 at 01:17:57PM +, Tvrtko Ursulin wrote: > >> On 24/11/15 12:53, Chris Wilson wrote: > >> >The WARN_ON is accurate though. The original patch fails

Re: [Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

2015-11-24 Thread Tvrtko Ursulin
On 24/11/15 13:27, Chris Wilson wrote: On Tue, Nov 24, 2015 at 01:17:57PM +, Tvrtko Ursulin wrote: On 24/11/15 12:53, Chris Wilson wrote: On Tue, Nov 24, 2015 at 11:58:22AM +0100, Daniel Vetter wrote: On Fri, Nov 20, 2015 at 01:23:36PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

2015-11-24 Thread Daniel Stone
Hi, On 24 November 2015 at 13:27, Chris Wilson wrote: > On Tue, Nov 24, 2015 at 01:17:57PM +, Tvrtko Ursulin wrote: >> On 24/11/15 12:53, Chris Wilson wrote: >> >The WARN_ON is accurate though. The original patch fails to fix even the >> >limited aspect of the bug it claimed to. >> >> That is

Re: [Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

2015-11-24 Thread Chris Wilson
On Tue, Nov 24, 2015 at 01:17:57PM +, Tvrtko Ursulin wrote: > > On 24/11/15 12:53, Chris Wilson wrote: > >On Tue, Nov 24, 2015 at 11:58:22AM +0100, Daniel Vetter wrote: > >>On Fri, Nov 20, 2015 at 01:23:36PM +, Tvrtko Ursulin wrote: > >>>From: Tvrtko Ursulin > >>> > >>>Commit e9f24d5fb7cf

Re: [Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

2015-11-24 Thread Tvrtko Ursulin
On 24/11/15 12:53, Chris Wilson wrote: On Tue, Nov 24, 2015 at 11:58:22AM +0100, Daniel Vetter wrote: On Fri, Nov 20, 2015 at 01:23:36PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Commit e9f24d5fb7cf3628b195b18ff3ac4e37937ceeae Author: Tvrtko Ursulin Date: Mon Oct 5 13:26:36 2015 +

Re: [Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

2015-11-24 Thread Chris Wilson
On Tue, Nov 24, 2015 at 11:58:22AM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2015 at 01:23:36PM +, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > Commit e9f24d5fb7cf3628b195b18ff3ac4e37937ceeae > > Author: Tvrtko Ursulin > > Date: Mon Oct 5 13:26:36 2015 +0100 > > > > drm/

Re: [Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

2015-11-24 Thread Daniel Vetter
On Fri, Nov 20, 2015 at 01:23:36PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Commit e9f24d5fb7cf3628b195b18ff3ac4e37937ceeae > Author: Tvrtko Ursulin > Date: Mon Oct 5 13:26:36 2015 +0100 > > drm/i915: Clean up associated VMAs on context destruction > > Added a warning base

[Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

2015-11-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Commit e9f24d5fb7cf3628b195b18ff3ac4e37937ceeae Author: Tvrtko Ursulin Date: Mon Oct 5 13:26:36 2015 +0100 drm/i915: Clean up associated VMAs on context destruction Added a warning based on an incorrect assumption that all VMAs in a VM will be on the inactive list at