Re: [Intel-gfx] [PATCH] drm/i915: RMW register cycles considered evil

2015-07-07 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6729 -Summary- Platform Delta drm-intel-nightly Series Applied ILK -1

Re: [Intel-gfx] [PATCH] drm/i915: RMW register cycles considered evil

2015-07-06 Thread Daniel Vetter
On Mon, Jul 06, 2015 at 04:23:23PM -0300, Paulo Zanoni wrote: > 2015-07-06 12:04 GMT-03:00 Daniel Vetter : > > On Mon, Jul 06, 2015 at 03:50:49PM +0300, Ville Syrjälä wrote: > >> On Mon, Jul 06, 2015 at 02:42:02PM +0200, Daniel Vetter wrote: > >> > Especially for workarounds which is stuff that's a

Re: [Intel-gfx] [PATCH] drm/i915: RMW register cycles considered evil

2015-07-06 Thread Paulo Zanoni
2015-07-06 12:04 GMT-03:00 Daniel Vetter : > On Mon, Jul 06, 2015 at 03:50:49PM +0300, Ville Syrjälä wrote: >> On Mon, Jul 06, 2015 at 02:42:02PM +0200, Daniel Vetter wrote: >> > Especially for workarounds which is stuff that's almost impossible to >> > verify: The initial state from the firmware o

Re: [Intel-gfx] [PATCH] drm/i915: RMW register cycles considered evil

2015-07-06 Thread Daniel Vetter
On Mon, Jul 06, 2015 at 04:15:25PM +0100, Damien Lespiau wrote: > On Mon, Jul 06, 2015 at 04:58:19PM +0200, Daniel Vetter wrote: > > On Mon, Jul 06, 2015 at 01:46:19PM +0100, Damien Lespiau wrote: > > > On Mon, Jul 06, 2015 at 02:42:02PM +0200, Daniel Vetter wrote: > > > > Especially for workaround

Re: [Intel-gfx] [PATCH] drm/i915: RMW register cycles considered evil

2015-07-06 Thread Damien Lespiau
On Mon, Jul 06, 2015 at 04:58:19PM +0200, Daniel Vetter wrote: > On Mon, Jul 06, 2015 at 01:46:19PM +0100, Damien Lespiau wrote: > > On Mon, Jul 06, 2015 at 02:42:02PM +0200, Daniel Vetter wrote: > > > Especially for workarounds which is stuff that's almost impossible to > > > verify: The initial s

Re: [Intel-gfx] [PATCH] drm/i915: RMW register cycles considered evil

2015-07-06 Thread Daniel Vetter
On Mon, Jul 06, 2015 at 03:50:49PM +0300, Ville Syrjälä wrote: > On Mon, Jul 06, 2015 at 02:42:02PM +0200, Daniel Vetter wrote: > > Especially for workarounds which is stuff that's almost impossible to > > verify: The initial state from the firmware on boot-up and after > > resume could be differen

Re: [Intel-gfx] [PATCH] drm/i915: RMW register cycles considered evil

2015-07-06 Thread Daniel Vetter
On Mon, Jul 06, 2015 at 03:07:16PM +0100, Dave Gordon wrote: > On 06/07/15 13:50, Ville Syrjälä wrote: > >On Mon, Jul 06, 2015 at 02:42:02PM +0200, Daniel Vetter wrote: > >>Especially for workarounds which is stuff that's almost impossible to > >>verify: The initial state from the firmware on boot-

Re: [Intel-gfx] [PATCH] drm/i915: RMW register cycles considered evil

2015-07-06 Thread Daniel Vetter
On Mon, Jul 06, 2015 at 01:46:19PM +0100, Damien Lespiau wrote: > On Mon, Jul 06, 2015 at 02:42:02PM +0200, Daniel Vetter wrote: > > Especially for workarounds which is stuff that's almost impossible to > > verify: The initial state from the firmware on boot-up and after > > resume could be differe

Re: [Intel-gfx] [PATCH] drm/i915: RMW register cycles considered evil

2015-07-06 Thread Dave Gordon
On 06/07/15 13:50, Ville Syrjälä wrote: On Mon, Jul 06, 2015 at 02:42:02PM +0200, Daniel Vetter wrote: Especially for workarounds which is stuff that's almost impossible to verify: The initial state from the firmware on boot-up and after resume could be different, which will hide bugs when we do

Re: [Intel-gfx] [PATCH] drm/i915: RMW register cycles considered evil

2015-07-06 Thread Ville Syrjälä
On Mon, Jul 06, 2015 at 02:42:02PM +0200, Daniel Vetter wrote: > Especially for workarounds which is stuff that's almost impossible to > verify: The initial state from the firmware on boot-up and after > resume could be different, which will hide bugs when we do an RMW > cycle. If you're really wo

Re: [Intel-gfx] [PATCH] drm/i915: RMW register cycles considered evil

2015-07-06 Thread Damien Lespiau
On Mon, Jul 06, 2015 at 02:42:02PM +0200, Daniel Vetter wrote: > Especially for workarounds which is stuff that's almost impossible to > verify: The initial state from the firmware on boot-up and after > resume could be different, which will hide bugs when we do an RMW > cycle. > > Hence never do

[Intel-gfx] [PATCH] drm/i915: RMW register cycles considered evil

2015-07-06 Thread Daniel Vetter
Especially for workarounds which is stuff that's almost impossible to verify: The initial state from the firmware on boot-up and after resume could be different, which will hide bugs when we do an RMW cycle. Hence never do them, and if it's required we need a special mask. Cc: Damien Lespiau Cc: