Re: [Intel-gfx] [PATCH] drm/i915: Quirk the pipe A quirk in the modeset state checker

2013-05-29 Thread Daniel Vetter
On Wed, May 29, 2013 at 10:06:20AM +0100, Chris Wilson wrote: > On Wed, May 29, 2013 at 10:41:29AM +0200, Daniel Vetter wrote: > > If we always force the pipe A to on we can't use the hw state to > > decide whether it should be on. Hence quirk the quirk. > > > > The problem is that crtc->active tr

Re: [Intel-gfx] [PATCH] drm/i915: Quirk the pipe A quirk in the modeset state checker

2013-05-29 Thread Chris Wilson
On Wed, May 29, 2013 at 10:41:29AM +0200, Daniel Vetter wrote: > If we always force the pipe A to on we can't use the hw state to > decide whether it should be on. Hence quirk the quirk. > > The problem is that crtc->active tracks the state of the entire > display pipe, i.e. including planes, enco

[Intel-gfx] [PATCH] drm/i915: Quirk the pipe A quirk in the modeset state checker

2013-05-29 Thread Daniel Vetter
If we always force the pipe A to on we can't use the hw state to decide whether it should be on. Hence quirk the quirk. The problem is that crtc->active tracks the state of the entire display pipe, i.e. including planes, encoders and all. But our hw state readout simply looks at the pipe. But with

Re: [Intel-gfx] [PATCH] drm/i915: Quirk the pipe A quirk in the modeset state checker

2013-05-29 Thread Chris Wilson
On Wed, May 29, 2013 at 10:09:34AM +0200, Daniel Vetter wrote: > On Wed, May 29, 2013 at 9:54 AM, Chris Wilson > wrote: > > On Wed, May 29, 2013 at 09:28:22AM +0200, Daniel Vetter wrote: > >> If we always force the pipe A to on we can't use the hw state to > >> decide whether it should be on. Hen

Re: [Intel-gfx] [PATCH] drm/i915: Quirk the pipe A quirk in the modeset state checker

2013-05-29 Thread Daniel Vetter
On Wed, May 29, 2013 at 9:54 AM, Chris Wilson wrote: > On Wed, May 29, 2013 at 09:28:22AM +0200, Daniel Vetter wrote: >> If we always force the pipe A to on we can't use the hw state to >> decide whether it should be on. Hence quirk the quirk. > > This is misleading as it is not the hw state that

Re: [Intel-gfx] [PATCH] drm/i915: Quirk the pipe A quirk in the modeset state checker

2013-05-29 Thread Chris Wilson
On Wed, May 29, 2013 at 09:28:22AM +0200, Daniel Vetter wrote: > If we always force the pipe A to on we can't use the hw state to > decide whether it should be on. Hence quirk the quirk. This is misleading as it is not the hw state that is unreliable, but crtc->active that is a misnomer. The quirk

[Intel-gfx] [PATCH] drm/i915: Quirk the pipe A quirk in the modeset state checker

2013-05-29 Thread Daniel Vetter
If we always force the pipe A to on we can't use the hw state to decide whether it should be on. Hence quirk the quirk. Note that in the hw state readout we don't really care since we have a big hack to force-enable pipe A anyway. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64764 Cc: s