Re: [Intel-gfx] [PATCH] drm/i915: Pull seqno started checks together

2018-08-07 Thread Chris Wilson
Quoting Mika Kuoppala (2018-08-07 10:09:48) > Chris Wilson writes: > > > We have a few instances of checking seqno-1 to see if the HW has started > > the request. Pull those together under a helper. > > > > v2: Pull the !seqno assertion higher, as we given seqno==1 we may indeed > > check to see

Re: [Intel-gfx] [PATCH] drm/i915: Pull seqno started checks together

2018-08-07 Thread Mika Kuoppala
Chris Wilson writes: > We have a few instances of checking seqno-1 to see if the HW has started > the request. Pull those together under a helper. > > v2: Pull the !seqno assertion higher, as we given seqno==1 we may indeed > check to see if we have started using seqno==0. > > Suggested-by: Tvrtk

[Intel-gfx] [PATCH] drm/i915: Pull seqno started checks together

2018-08-06 Thread Chris Wilson
We have a few instances of checking seqno-1 to see if the HW has started the request. Pull those together under a helper. v2: Pull the !seqno assertion higher, as we given seqno==1 we may indeed check to see if we have started using seqno==0. Suggested-by: Tvrtko Ursulin Signed-off-by: Chris Wil

Re: [Intel-gfx] [PATCH] drm/i915: Pull seqno started checks together

2018-08-06 Thread Chris Wilson
Quoting Mika Kuoppala (2018-08-06 12:17:16) > Chris Wilson writes: > > > We have a few instances of checking seqno-1 to see if the HW has started > > the request. Pull those together under a helper. > > > > Could you elaborate why you want both completed and signaled? Purely on context. In some

Re: [Intel-gfx] [PATCH] drm/i915: Pull seqno started checks together

2018-08-06 Thread Mika Kuoppala
Chris Wilson writes: > We have a few instances of checking seqno-1 to see if the HW has started > the request. Pull those together under a helper. > Could you elaborate why you want both completed and signaled? Otherwise it looks good. -Mika > Suggested-by: Tvrtko Ursulin > Signed-off-by: Chri

[Intel-gfx] [PATCH] drm/i915: Pull seqno started checks together

2018-08-06 Thread Chris Wilson
We have a few instances of checking seqno-1 to see if the HW has started the request. Pull those together under a helper. Suggested-by: Tvrtko Ursulin Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_request.c | 9 +++--- drivers/gpu/drm/i915/i915_request.h