Re: [Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-03-30 Thread Chris Wilson
On Wed, Mar 30, 2016 at 06:57:14PM +0100, Chris Wilson wrote: > If the initialisation fails, we may be left with a dangling pointer with > an incomplete fbdev structure. Here we want to disable internal calls > into fbdev. Similarly, the initialisation may be slow and we haven't yet > enabled the f

Re: [Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-03-30 Thread kbuild test robot
Hi Chris, [auto build test ERROR on drm-intel/for-linux-next] [cannot apply to v4.6-rc1 next-20160330] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Protect-fbdev-across

Re: [Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-03-30 Thread kbuild test robot
Hi Chris, [auto build test WARNING on drm-intel/for-linux-next] [cannot apply to v4.6-rc1 next-20160330] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Protect-fbdev-acro

Re: [Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-03-30 Thread kbuild test robot
Hi Chris, [auto build test ERROR on drm-intel/for-linux-next] [cannot apply to v4.6-rc1 next-20160330] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Protect-fbdev-across

[Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-03-30 Thread Chris Wilson
If the initialisation fails, we may be left with a dangling pointer with an incomplete fbdev structure. Here we want to disable internal calls into fbdev. Similarly, the initialisation may be slow and we haven't yet enabled the fbdev (e.g. quick suspend or last-close before the async init completes

Re: [Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-02-15 Thread Daniel Vetter
On Fri, Feb 05, 2016 at 03:58:31PM +0100, Lukas Wunner wrote: > Hi Chris, > > On Fri, Feb 05, 2016 at 11:09:27AM +, Chris Wilson wrote: > > On Fri, Feb 05, 2016 at 01:27:10AM +0100, Lukas Wunner wrote: > > > On Thu, Feb 04, 2016 at 09:21:17AM +, Li, Weinan Z wrote: > > > > We still need th

Re: [Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-02-05 Thread Lukas Wunner
Hi Chris, On Fri, Feb 05, 2016 at 11:09:27AM +, Chris Wilson wrote: > On Fri, Feb 05, 2016 at 01:27:10AM +0100, Lukas Wunner wrote: > > On Thu, Feb 04, 2016 at 09:21:17AM +, Li, Weinan Z wrote: > > > We still need this patch. Seems 54632abe8ca3 ("drm/i915: Fix oops caused > > > by fbdev i

Re: [Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-02-05 Thread Chris Wilson
On Fri, Feb 05, 2016 at 01:27:10AM +0100, Lukas Wunner wrote: > Hi, > > On Thu, Feb 04, 2016 at 09:21:17AM +, Li, Weinan Z wrote: > > We still need this patch. Seems 54632abe8ca3 ("drm/i915: Fix oops caused by > > fbdev initialization > > failure") as well as 366e39b4d2c5 ("drm/i915: Tear dow

Re: [Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-02-04 Thread Lukas Wunner
l...@gmail.com'; Lukas Wunner > Cc: Chris Wilson; > intel-gfx@lists.freedesktop.org<mailto:intel-gfx@lists.freedesktop.org> > Subject: RE: [Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or > failed initialisation > > Thanks for your quick response. > Yes it

Re: [Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-02-04 Thread Gustav Fägerlind
Cool, thank you. I dont believe I can easily reproduce it, it has only happend few times (and i reboot my lappy >2 times per day). // Gustav 2016-02-03 14:25 GMT+01:00 Lukas Wunner : > Hi, > > On Wed, Feb 03, 2016 at 09:17:37AM +, Chris Wilson wrote: > > If the initialisation fails, we may b

Re: [Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-02-04 Thread Li, Weinan Z
ut not text mode to reproduce this issue. BRs, Weinan Li From: Gustav Fägerlind [mailto:gustav.fagerl...@gmail.com] Sent: Thursday, February 04, 2016 1:08 AM To: Lukas Wunner Cc: Chris Wilson; intel-gfx@lists.freedesktop.org<mailto:intel-gfx@lists.freedesktop.org>; Li, Weinan Z Subject:

Re: [Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-02-03 Thread Li, Weinan Z
[mailto:gustav.fagerl...@gmail.com] Sent: Thursday, February 04, 2016 1:08 AM To: Lukas Wunner Cc: Chris Wilson; intel-gfx@lists.freedesktop.org; Li, Weinan Z Subject: Re: [Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation Cool, thank you. I dont believe I can easily

Re: [Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-02-03 Thread Lukas Wunner
Hi, On Wed, Feb 03, 2016 at 09:17:37AM +, Chris Wilson wrote: > If the initialisation fails, we may be left with a dangling pointer with > an incomplete fbdev structure. This shouldn't happen with 4.5, the fbdev is now clobbered if initialization fails, the existing "if (dev_priv->fbdev)" che

[Intel-gfx] [PATCH] drm/i915: Protect fbdev across slow or failed initialisation

2016-02-03 Thread Chris Wilson
If the initialisation fails, we may be left with a dangling pointer with an incomplete fbdev structure. Here we want to disable internal calls into fbdev. Similarly, the initialisation may be slow and we haven't yet enabled the fbdev (e.g. quick suspend or last-close before the async init completes