Re: [Intel-gfx] [PATCH] drm/i915: Print error state times relative to capture

2018-05-02 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2018-04-27 16:12:48) >> @@ -427,8 +428,10 @@ static void error_print_context(struct >> drm_i915_error_state_buf *m, >> } >> >> static void error_print_engine(struct drm_i915_error_state_buf *m, >> - const struct drm_i

Re: [Intel-gfx] [PATCH] drm/i915: Print error state times relative to capture

2018-04-27 Thread Chris Wilson
Quoting Mika Kuoppala (2018-04-27 16:12:48) > @@ -427,8 +428,10 @@ static void error_print_context(struct > drm_i915_error_state_buf *m, > } > > static void error_print_engine(struct drm_i915_error_state_buf *m, > - const struct drm_i915_error_engine *ee) > +

[Intel-gfx] [PATCH] drm/i915: Print error state times relative to capture

2018-04-27 Thread Mika Kuoppala
Using plain jiffies in error state output makes the output time differences relative to the current system time. This is wrong as it makes output time differences dependent of when the error state is printed rather than when it is captured. Store capture jiffies into error state and use it when ou

Re: [Intel-gfx] [PATCH] drm/i915: Print error state times relative to capture

2018-04-16 Thread Chris Wilson
Quoting Mika Kuoppala (2018-04-16 14:40:52) > Using plain jiffies in error state output makes the output > time differences relative to the current system time. This > is wrong as it makes output time differences dependent > of when the error state is printed rather than when it is > captured. > >

[Intel-gfx] [PATCH] drm/i915: Print error state times relative to capture

2018-04-16 Thread Mika Kuoppala
Using plain jiffies in error state output makes the output time differences relative to the current system time. This is wrong as it makes output time differences dependent of when the error state is printed rather than when it is captured. Store capture jiffies into error state and use it when ou