Re: [Intel-gfx] [PATCH] drm/i915: Optimise VMA lookup slightly

2016-12-13 Thread Tvrtko Ursulin
On 13/12/2016 13:41, Chris Wilson wrote: On Tue, Dec 13, 2016 at 01:30:19PM +, Tvrtko Ursulin wrote: On 13/12/2016 12:41, Chris Wilson wrote: On Tue, Dec 13, 2016 at 12:22:18PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin A few details to hopefully make a very hot function a tiny

Re: [Intel-gfx] [PATCH] drm/i915: Optimise VMA lookup slightly

2016-12-13 Thread Chris Wilson
On Tue, Dec 13, 2016 at 01:30:19PM +, Tvrtko Ursulin wrote: > > On 13/12/2016 12:41, Chris Wilson wrote: > >On Tue, Dec 13, 2016 at 12:22:18PM +, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>A few details to hopefully make a very hot function a tiny bit > >>more efficient: > >>

Re: [Intel-gfx] [PATCH] drm/i915: Optimise VMA lookup slightly

2016-12-13 Thread Tvrtko Ursulin
On 13/12/2016 12:41, Chris Wilson wrote: On Tue, Dec 13, 2016 at 12:22:18PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin A few details to hopefully make a very hot function a tiny bit more efficient: 1. Cast VM pointers before substraction to save the compiler doing a smart one whi

Re: [Intel-gfx] [PATCH] drm/i915: Optimise VMA lookup slightly

2016-12-13 Thread Chris Wilson
On Tue, Dec 13, 2016 at 12:22:18PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > A few details to hopefully make a very hot function a tiny bit > more efficient: > > 1. Cast VM pointers before substraction to save the compiler > doing a smart one which includes multiplication. In

[Intel-gfx] [PATCH] drm/i915: Optimise VMA lookup slightly

2016-12-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A few details to hopefully make a very hot function a tiny bit more efficient: 1. Cast VM pointers before substraction to save the compiler doing a smart one which includes multiplication. 2. Use smaller type for comparison since we only care about the sign. 3.