Re: [Intel-gfx] [PATCH] drm/i915: Only write watermark registers if a pipe is active

2016-03-07 Thread Matt Roper
On Mon, Mar 07, 2016 at 04:29:04PM +0200, Ville Syrjälä wrote: > On Fri, Mar 04, 2016 at 03:49:02PM -0800, Matt Roper wrote: > > On Fri, Mar 04, 2016 at 12:52:41PM +0200, Ville Syrjälä wrote: > > > On Thu, Mar 03, 2016 at 02:27:21PM -0800, Matt Roper wrote: > > > > If all pipes are off, then we may

Re: [Intel-gfx] [PATCH] drm/i915: Only write watermark registers if a pipe is active

2016-03-07 Thread Ville Syrjälä
On Fri, Mar 04, 2016 at 03:49:02PM -0800, Matt Roper wrote: > On Fri, Mar 04, 2016 at 12:52:41PM +0200, Ville Syrjälä wrote: > > On Thu, Mar 03, 2016 at 02:27:21PM -0800, Matt Roper wrote: > > > If all pipes are off, then we may have entered runtime suspend and > > > writing these registers will ha

Re: [Intel-gfx] [PATCH] drm/i915: Only write watermark registers if a pipe is active

2016-03-04 Thread Matt Roper
On Fri, Mar 04, 2016 at 12:52:41PM +0200, Ville Syrjälä wrote: > On Thu, Mar 03, 2016 at 02:27:21PM -0800, Matt Roper wrote: > > If all pipes are off, then we may have entered runtime suspend and > > writing these registers will have no effect anyway. When a pipe is > > re-enabled, it's crtc_enabl

Re: [Intel-gfx] [PATCH] drm/i915: Only write watermark registers if a pipe is active

2016-03-04 Thread Ville Syrjälä
On Thu, Mar 03, 2016 at 02:27:21PM -0800, Matt Roper wrote: > If all pipes are off, then we may have entered runtime suspend and > writing these registers will have no effect anyway. When a pipe is > re-enabled, it's crtc_enable will take care of programming appropriate > watermark values. > > Cc

[Intel-gfx] [PATCH] drm/i915: Only write watermark registers if a pipe is active

2016-03-03 Thread Matt Roper
If all pipes are off, then we may have entered runtime suspend and writing these registers will have no effect anyway. When a pipe is re-enabled, it's crtc_enable will take care of programming appropriate watermark values. Cc: arun.siluv...@linux.intel.com Cc: ville.syrj...@linux.intel.com Bugzil