Re: [Intel-gfx] [PATCH] drm/i915: Only force GGTT coherency w/a on required chipsets

2018-07-20 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-07-20 16:13:14) > > On 20/07/2018 11:19, Chris Wilson wrote: > > +/* > > + * Once upon a time we supposed that writes through the GGTT would be > > + * immediately in physical memory (once flushed out of the CPU path). > > However, > > + * on a few different processor

Re: [Intel-gfx] [PATCH] drm/i915: Only force GGTT coherency w/a on required chipsets

2018-07-20 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-07-20 16:27:20) > > On 20/07/2018 16:21, Chris Wilson wrote: > > My only plan is for igt to know when the tests are expected to fail. > > Real userspace should not be using GTT, it is slow (even slower than > > intended ;) and constrained, so subject to aperture thrash

Re: [Intel-gfx] [PATCH] drm/i915: Only force GGTT coherency w/a on required chipsets

2018-07-20 Thread Tvrtko Ursulin
On 20/07/2018 16:21, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-07-20 16:13:14) On 20/07/2018 11:19, Chris Wilson wrote: Not all chipsets have an internal buffer delaying the visibility of writes via the GGTT being visible by other physical paths, but we use a very heavy workaround for

Re: [Intel-gfx] [PATCH] drm/i915: Only force GGTT coherency w/a on required chipsets

2018-07-20 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-07-20 16:13:14) > > On 20/07/2018 11:19, Chris Wilson wrote: > > Not all chipsets have an internal buffer delaying the visibility of > > writes via the GGTT being visible by other physical paths, but we use a > > very heavy workaround for all. We only need to apply tha

Re: [Intel-gfx] [PATCH] drm/i915: Only force GGTT coherency w/a on required chipsets

2018-07-20 Thread Tvrtko Ursulin
On 20/07/2018 11:19, Chris Wilson wrote: Not all chipsets have an internal buffer delaying the visibility of writes via the GGTT being visible by other physical paths, but we use a very heavy workaround for all. We only need to apply that workarounds to the chipsets we know suffer from the delay

Re: [Intel-gfx] [PATCH] drm/i915: Only force GGTT coherency w/a on required chipsets

2018-07-20 Thread Chris Wilson
Quoting Lis, Tomasz (2018-07-20 15:41:33) > > > On 2018-07-20 12:19, Chris Wilson wrote: > > Not all chipsets have an internal buffer delaying the visibility of > > writes via the GGTT being visible by other physical paths, but we use a > > very heavy workaround for all. We only need to apply tha

Re: [Intel-gfx] [PATCH] drm/i915: Only force GGTT coherency w/a on required chipsets

2018-07-20 Thread Lis, Tomasz
On 2018-07-20 12:19, Chris Wilson wrote: Not all chipsets have an internal buffer delaying the visibility of writes via the GGTT being visible by other physical paths, but we use a very heavy workaround for all. We only need to apply that workarounds to the chipsets we know suffer from the dela

[Intel-gfx] [PATCH] drm/i915: Only force GGTT coherency w/a on required chipsets

2018-07-20 Thread Chris Wilson
Not all chipsets have an internal buffer delaying the visibility of writes via the GGTT being visible by other physical paths, but we use a very heavy workaround for all. We only need to apply that workarounds to the chipsets we know suffer from the delay and the resulting coherency issue. Similar

Re: [Intel-gfx] [PATCH] drm/i915: Only force GGTT coherency w/a on required chipsets

2018-07-20 Thread Ville Syrjälä
On Fri, Jul 20, 2018 at 08:59:31AM +0100, Chris Wilson wrote: > Not all chipsets have an internal buffer delaying the visibility of > writes via the GGTT being visible by other physical paths, but we use a > very heavy workaround for all. We only need to apply that workarounds to > the chipsets we

[Intel-gfx] [PATCH] drm/i915: Only force GGTT coherency w/a on required chipsets

2018-07-20 Thread Chris Wilson
Not all chipsets have an internal buffer delaying the visibility of writes via the GGTT being visible by other physical paths, but we use a very heavy workaround for all. We only need to apply that workarounds to the chipsets we know suffer from the delay and the resulting coherency issue. Similar